Message-ID: <ac52a6aa6be9ccf5cf43c44d009b6e2aa7e2c93d.camel@j-davis.com>
Subject: Re: Avoid orphaned objects dependencies, take 3
From: Jeff Davis <pgsql@j-davis.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Robert Haas
 <robertmhaas@gmail.com>,  Roman Eskin <r.eskin@arenadata.io>, Michael
 Paquier <michael@paquier.xyz>, Alexander Lakhin <exclusion@gmail.com>,
 pgsql-hackers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 16 Jun 2026 12:14:12 -0700
In-Reply-To: <ajEg7PrJYWnmB6zk@bdtpg>
References: <3963e573-4852-4d25-b741-7c5c7e1f9140@iki.fi>
	 <ah1PIyqtT+427dWb@bdtpg>
	 <02e28438bd448ff4ee8f6fd78e6b74e657172d73.camel@j-davis.com>
	 <aiLKkTC6QBt8i35P@bdtpg>
	 <71eb9a8835a28165939da567a9d649fe6d21bfa7.camel@j-davis.com>
	 <aie26jMSoEMrHLaI@bdtpg>
	 <0fc145b9b5cf3f59207cf4ca60270448a2891c46.camel@j-davis.com>
	 <ailZCCmS0bGlNBfe@bdtpg> <ail/6I6mcitovsUo@bdtpg>
	 <a9eba27eeceebe751490951f0cf631906d4ffd75.camel@j-davis.com>
	 <ajEg7PrJYWnmB6zk@bdtpg>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.3-0ubuntu1.1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/ac52a6aa6be9ccf5cf43c44d009b6e2aa7e2c93d.camel%40j-davis.com>
Precedence: bulk

On Tue, 2026-06-16 at 10:09 +0000, Bertrand Drouvot wrote:
> 0002: fixes it by moving aclcheck_track_record() to after the
> permission check
> succeeds in object_aclcheck_ext() and pg_class_aclcheck_ext().
> Indeed, there is
> no need to track failed permission checks.

IIUC, this is necessary for correctness. If an ACL failure doesn't
cause a transaction abort, then there's a danger that we cause the
transaction to fail that should have succeeded.

So the ACL tracking needs to be precise: we can't track an ACL check
unless a failure always causes transaction abort; and we must track an
ACL check if it would cause a transaction abort. Right?

Regards,
	Jeff Davis