Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 23 Mar 2026 09:31:36 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jianghua Yang <yjhjstz@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: basebackup: add missing deflateEnd() in gzip compression sink
Message-ID: <acCJ6C-LHbJWSVEJ@paquier.xyz>
References: 
 <CAAZLFmQNJ0QNArpWEOZXwv=vbumcWKEHz-b1me5gBqRqG67EwQ@mail.gmail.com>
 <ab42G_tMNfBtULhZ@paquier.xyz>
 <CAAZLFmQeS4AFC6mNQNhyZWGUMXEkOmQA11UL28N-6c=CYtqnoA@mail.gmail.com>
 <CAAZLFmQOH+fy6=ybEQ-xGdX9Zee2xkXhfuzCfbWweXxJ_6iD-A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="813im3pBb72QsgIe"
Content-Disposition: inline
In-Reply-To: 
 <CAAZLFmQOH+fy6=ybEQ-xGdX9Zee2xkXhfuzCfbWweXxJ_6iD-A@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/acCJ6C-LHbJWSVEJ%40paquier.xyz>
Precedence: bulk


--813im3pBb72QsgIe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Mar 21, 2026 at 02:22:25PM -0700, Jianghua Yang wrote:
> v1-0001: basebackup: add missing deflateEnd() calls in gzip compression
> sink

After double-checking the whole code, I agree that this is a good
practice to have in the tree.  However, the issue is not worth
bothering in back-branches as the server-side base backup gzip code
relies on allocation and free callbacks, with zlib internals doing
nothing with fds or more persistent states as far as I have read its
code.  For the current use, we'd bloat this data once per tablespace
in a single base backup, safe even if the connection is persistent
(missed that in my first message).

What I am more worried about are future callers of this code, though,
and we care about having a end() call for each matching init[2]() call
in the tree in all the places that rely on gzip internals.  So that's
a good practice on consistency ground, at least.  For these reasons,
applied that on HEAD.

> v1-0002: pg_basebackup: add missing close() for incremental manifest
> file

This one does not matter.  This resource is for a backup manifest and
we are talking about a single one for a single invocation of the
binary.
--
Michael

--813im3pBb72QsgIe
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnAiegACgkQnvQgOdby
QH0kXg//RKh/HyIHeIZsowtMBiSzwY9HhwUUjgu1t9qA34+u3GcvYANotuBHIntJ
eF6HiTWt4dR1DrPDaHuDSI4WlcmXxfM4D86tpUiLXPIin8xSfgCSEP4c1cGrVsrU
zuAupwjwPV2b4XVotljQSYsoA8B1IbMGsaVJzZRWXyIb6NvXstOBM7KZYiCMcGiS
pf2IgKKDKBfK+8QigRxgN7jkFUlfEXqb9cSuMla/79l/KNlEiqE6pHA9ocND0Cbn
v17Qgoe11dpW8gGx53mbp0Gv1zkPVLo1Z99xpSoe1wHUCZSTnn0M1XrQ2fRkzqMo
aC3A69W49hxaHnRtT+Ikg/HyR0jpn/TqfgdNcMXkyNBwwuz6i3azq3nFC65fn9BO
XAXKFLsGr0N6nGYbDbdE8xsfX/sz2tqz1hh7QNSl85ma7LK3wCvkgO3MYswk0R0D
MirtMGxXN8kSOjRI1kvdfuF468meZo4oKoto/Bu5rgyepugRNabu0jShrr3gmsEL
QQ+cYxNSpG+sldnULcSzF3FIR47nPkRCZB61H0oBwVUNisnjirdl8Xv8ByVGOl3H
NXcVtN00OGRuwr63o3X9d+x+KHW6nATWTlDJfUxFM2OQmvm9hd6RBKH+SPINLAGS
CW8KXKp7l3eBEJgMy5RwlJvxINb26pvinxCcntJvMM46xVXjQbA=
=MMzp
-----END PGP SIGNATURE-----

--813im3pBb72QsgIe--