Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 25 Mar 2026 11:28:17 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Pang <robertpang@google.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Fix premature timeout in pg_promote() caused by signal
 interruptions
Message-ID: <acNIQaeIg88xkCNC@paquier.xyz>
References: 
 <CAJhEC07OK8J7tLUbyiccnuOXRE7UKxBNqD2-pLfeFXa=tBoWtw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2CiSH/75PhcvBTdO"
Content-Disposition: inline
In-Reply-To: 
 <CAJhEC07OK8J7tLUbyiccnuOXRE7UKxBNqD2-pLfeFXa=tBoWtw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/acNIQaeIg88xkCNC%40paquier.xyz>
Precedence: bulk


--2CiSH/75PhcvBTdO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 11, 2026 at 09:44:07AM -0700, Robert Pang wrote:
> The current implementation of pg_promote() calculates a fixed number
> of loop iterations based on the timeout value, assuming each loop
> waits exactly 100 ms for the backend latch. However, if the backend
> receives an unrelated signal (e.g., from
> client_connection_check_interval), it wakes up early. These repeated,
> unrelated wakeups cause the loop counter to deplete much faster than
> intended, leading to a premature timeout.

It is true that we can do better here, and your proposal about having
a more precise timeout calculation looks like a sensible improvement
for this case.

No objections regarding your patch.  I would like to apply it on HEAD,
if there are no objections.
--
Michael

--2CiSH/75PhcvBTdO
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnDSEEACgkQnvQgOdby
QH1i4A//f+/y3EP9uTzWVIO3+m/Z0pQLEagiELlBpd8i3KsLj0LX1sjtcu3m/ESa
dJRsFNYOKcGwIDaZFCQHfvaJvFBqJfKFfJ5dURszBLAguSSo3eNz6/HdD5Lu2RGb
WY3yO6Foyg6SXQ54NAZdhzi/673hzUFSH57QJrjHPN9v2PZRHf5oH5TnaXMac4Fm
HUbDN5YrhGAiRoYuE3Hcl2cGE3uCyTViAYf1SAKtqJdi80J0mjPZ0fkXvocHkPnM
8/+TjSXXk8japgh9fBpvJ4dKWYBbYd62aVoUs39daL+Gs7P5MKAqEljIia+UIyfO
wQRWEQdHZIAPWUegLqRYFlDWDc7MCKYQyNcFR2HSmg5n1YVorBLcOzzEKPHq/+mt
CCQ+e3Af0aRA4LurGUAi0zc2KEO+JozFUT3Oi0no9Mz3cYLjm68sIEYjzTNwnxvn
vls5RXwaMmPOateddViqdP1snbYeMQyxuTkoNF/+i4zzmeEcTlHFxpRBFRYB9E7I
W2O3Gk+vqBXuauyPioIlXE0e5tRC0bNcpj5tD9f79clK+TUrcXrIqV7RToXTtYfH
3epsOMN4l9n3o8maLio0umxETLZceRTbrvaVqmQxPiwc1ha/0cBzhtYekd9PtxA2
Rd9pmHm3uezLP69r7lvZ8ZojJjdpwkrdhcV34NEMqKE/Di5SE+0=
=01+R
-----END PGP SIGNATURE-----

--2CiSH/75PhcvBTdO--