Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w5EkZ-0032id-09 for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Mar 2026 03:17:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w5EkX-00BAcu-1U for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Mar 2026 03:17:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w5EkX-00BAcm-0c for pgsql-hackers@lists.postgresql.org; Wed, 25 Mar 2026 03:17:41 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w5EkU-00000000zZG-0AYg for pgsql-hackers@lists.postgresql.org; Wed, 25 Mar 2026 03:17:41 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-486fd3a577eso40457935e9.1 for ; Tue, 24 Mar 2026 20:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774408657; x=1775013457; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=x4+YdEovvULEbio5hLdkLVRgME4p7E8Bd/M2LiYTRO4=; b=Iv1awnIHBo+JYPa/mM9mW3iRziIjzOflX0D+dF8I9YI/6lVBfiNGo8yyNII4b3d+Vq PK3ZBjXS9Fg6Pfl+JJjgWlY074lhci02vdOU4LbvAx5OdNFZ0XopPhuU8zrZxNY2QJt6 vBWC2JAiaPV8p/iwUp0gbyWcae8NpjudkDyKA8WS3GHx5z++H2JwTIes175sz6c4vLWn jQ8iFhuf4h3yGZDZ+IaQQqq7SgiUD5/+jGlsa/wMAKboHauWZetSeWW7bg0J7FAzGtYf jIk18zrApHGXD1dn0Ci6l2T+LduJ6YnBMtO5/Qe0+C/fMLyoB9uz7inQLoUq7KC0pcW8 py4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774408657; x=1775013457; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x4+YdEovvULEbio5hLdkLVRgME4p7E8Bd/M2LiYTRO4=; b=iuc3M38hhqiHdyIHVa5C2k/19Iz1I+zwGqhiYV99rWTrIzy4qFQgUBxYLX2K8Y6jyt 1WZdaBEHFkHMonJ55k/Yp/c226K8wHbtNKPaF12s10glDtt6u/1aD07H6s4hiWuNgkEp TMApR/q4Potx3zT7bh8WBd1pGGtLABCsAWglIFIByu1PG+YfNgvEJjsnkRiz9WqkrgMF 0CD8Q7ScQpbBl18b0GhLo1CIwI6WgV09Q8Bg+GaZdvR+uWriHT7AmIsKU/vy7/fcf3Fb 85l8v6XvNJFLQnmEZRmB9ZjZI/vR+2yE/qh2mFUc/ZzU7jqgGNDzGHt8ZDfWk/Z7RG9X FhcQ== X-Gm-Message-State: AOJu0YysI0rhuK/5/c4DZnTYWsrE0NChIa8pQN2LzgucgxWzcq3ElLjR lw0C32vkbu/WsH5n6Xqcz5keL5d/w56/r8ovllDB0iHH4v+VSwMb1M6VJ2ojGw== X-Gm-Gg: ATEYQzyjlbWwM6oQ8V6gkDfJCxsuDP/e7ILzhsHaZzp7XVtKhPBelbFlePdkGT/kCn7 b4QJ/VHvuVrKeSMn3+beALnahovESajs8wse01DzTCUIMIMzaoEQ/UvArbZnQTuo3vGvtzi5NSS d6p8Khda/s9CYUP9byjYYXTYRCV942BavB9nGRxDYB8bKAMQ+Vov34Ihvh7oxby6B/tfiuw47ZH HsI2gE+hhdVhBUQ4kjOZo3o9lme8SePIcjHHdp+VyuY1FfBG/ruAcJvGA7qUbFkSZn+SLMk14d2 QNuyuKgqtXJ/Vg9f8beidYXLC8oYQB4aTNzCmGzA7tbE/jyV7KfPQ2fw+9CxwPzI6c2gy/3Ln83 VDsujki/VV4WJ011IrlVuEYSOaHQ/HBXEv78MOLuw1nDR5y28uABlaih31xVvDX3d2GazxkXVi5 ZWZZgNL8SkuO89cwKkf2GIQtWv2RPiqlZzXBEn60BRArfGbgyMjyouDCtg0FExewGfJafG3Qild WATcz3x/Hfcw3n1etSq0sPO9nKyRqOPIsnFcx2hyPKArNrOd0vN7y0d9w== X-Received: by 2002:a05:600c:a30d:b0:477:54f9:6ac2 with SMTP id 5b1f17b1804b1-48715f003e8mr24058275e9.0.1774408657443; Tue, 24 Mar 2026 20:17:37 -0700 (PDT) Received: from ip-10-97-1-34.eu-west-3.compute.internal (ec2-15-237-197-144.eu-west-3.compute.amazonaws.com. [15.237.197.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4871664ad92sm15167925e9.4.2026.03.24.20.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 20:17:36 -0700 (PDT) Date: Wed, 25 Mar 2026 03:17:35 +0000 From: Bertrand Drouvot To: Peter Eisentraut Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default Message-ID: References: <44885d54-0376-46b3-b574-59e0e3098580@eisentraut.org> <4ab608af-2f90-47d8-88a5-6329f6630fff@eisentraut.org> <6edd397a-dd66-4f0d-ac58-4193fb1ea3dd@eisentraut.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6edd397a-dd66-4f0d-ac58-4193fb1ea3dd@eisentraut.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Tue, Mar 24, 2026 at 10:36:43PM +0100, Peter Eisentraut wrote: > On 24.03.26 08:16, Bertrand Drouvot wrote: > > 0001: > > > > + '/external:anglebrackets', > > + '/external:W0', > > > > The doc [1], states: > > > > " > > The /external compiler options are available starting in Visual Studio 2017 version 15.6. > > In versions of Visual Studio before Visual Studio 2019 version 16.10, the /external > > options require you also set the /experimental:external compiler option. > > " > > > > We currently require MSVC 2019, but what if one is using a version < 16.10? > > Per discussion in [0] we effectively require 16.11, so I think this should > be ok. Agree, thanks for the link! Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com