Date: Wed, 25 Mar 2026 03:32:05 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>
Cc: Michael Paquier <michael@paquier.xyz>,
	Andres Freund <andres@anarazel.de>, Jeff Davis <pgsql@j-davis.com>,
	Greg Sabino Mullane <htamfids@gmail.com>,
	"L. pgsql-hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Adding locks statistics
Message-ID: <acNXNe99YN84ZbGk@ip-10-97-1-34.eu-west-3.compute.internal>
References: <acD3PUbZ0ZER+hCl@ip-10-97-1-34.eu-west-3.compute.internal>
 <202603241611.3vnou5cwxdpq@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202603241611.3vnou5cwxdpq@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/acNXNe99YN84ZbGk%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Tue, Mar 24, 2026 at 05:16:11PM +0100, Álvaro Herrera wrote:
> Hello,
> 
> On 2026-Mar-23, Bertrand Drouvot wrote:
> 
> > 2/ Not directly linked to your patches
> > 
> > It looks like that aio_funcs.c does not need lock.h (reported by include-what-you-use).
> > If we remove its direct include, it's still indirectly included through proc.h
> > though. But I think that removing its direct include makes sense as it's not
> > needed at all.
> 
> I'm not opposed to somebody else making this change, if they want, but I
> think there's little practical impact.

yeah, not sure it deserves its own commit... I was just mentioning here in case
you want to change that in passing while working on lock.h includes.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com