Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 25 Mar 2026 17:00:04 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@tigerdata.com>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	John Naylor <johncnaylorls@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: [PATCH] Simplify SortSupport implementation for macaddr
Message-ID: <acOWBAZpGw6XLThN@paquier.xyz>
References: 
 <CAJ7c6TMk10rF_LiMz6j9rRy1rqk-5s+wBPuBefLix4cY+-4s1w@mail.gmail.com>
 <932CBCA0-FF4B-406E-9296-1B8A63C3EB49@yandex-team.ru>
 <CAJ7c6TPoPMfGwVuM14T7KuWVcRaoE3-nd3goLoE5zss4JzAExw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="pMz4EgqzcDuo/M/K"
Content-Disposition: inline
In-Reply-To: 
 <CAJ7c6TPoPMfGwVuM14T7KuWVcRaoE3-nd3goLoE5zss4JzAExw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/acOWBAZpGw6XLThN%40paquier.xyz>
Precedence: bulk


--pMz4EgqzcDuo/M/K
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 09, 2026 at 04:08:06PM +0300, Aleksander Alekseev wrote:
>> 1. The assignment ssup->ssup_extra =3D NULL can be removed. The
>>    SortSupport struct is zeroed before the callback is called (see
>>    sortsupport.h). There are about 22 similar assignments elsewhere;
>>    it does not seem to be established practice, many other places have
>>    no such assignment.
>=20
> Agree. I removed this assignment in 0001 and added 0002 that removes
> if for the rest of *_sortsupport() functions.

Sounds sensible to get rid of the estimation with the Datum size
requirement and never give up with the abbreviated key sort, as done
in 0001.  I'd leave the code touched by 0002 remain as-is.

@Tom, why didn't you consider that as a continuation of 6aebedc38497?
Just to keep the changes with SIZEOF_DATUM < 8 leaner, or just because
it was not worth bothering based on your TODO list?  I am wondering if
there is a reason I may be missing here.
--
Michael

--pMz4EgqzcDuo/M/K
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnDlgQACgkQnvQgOdby
QH0MRRAAg0L7gkGXQbCcEM2/yOLpVK4SLOMfVsiD3qf3XdaRbFify3U2NVLdPLG1
Tk/LDs2O88QHD+0CYBd6dDMAVlfOWNBjmk1ZDuP/Y1Bc/Vm0Mghrn+7JSKaXCstI
q90N3Xg4t0+V8hnKUm8VtCvdXFUTM/1ip8VtZoa0mB6YjQTrbHTWyvhCKUBbyiDb
Hv0OJS76rhX126fBJjBmOkioqdpxQjuJsyOwoqjvzBEi2Cf1wGj1B6wHBfCIx2PA
q+Wm/qG1pcNOxFR17Iiogb+3hSj0HY3Pdd3oWjNDwou4x3CjF/SEmupMZoAOlVbL
7qrG+7wiXJzQMZ5LCwm5aRG2gh581VV57Y8zTA/4O3o5Vwfe9/CQdy7Cet9cT6Ds
rT39Cjf9tv++9nHsZr8T03JigPV0p4hpJvRQ5hX9JXqkbbzk0192u1ZuHdt7Jq1V
BMRdfSF7jBCXkz1EWuLuYEkiJyN/8QG+u8g8DaiYYv7hQkgIOoJ0uk9gs70goUXc
GobPRWbLONmtI1MZzGyvC08NdSHhFkMMfs7KJntnMNIFnbsPSd53OJHHEzBhve/2
mcY51fGr+3TvwkHKEUTAXnorebQedVb34qBLunPGYiRnnv0021H1A+dO0ctbnd2R
4afXOxStduMpTt8bjVToZIX8GA+JbPWTBgKZ6XU4eHoyWJaEwAU=
=cpPe
-----END PGP SIGNATURE-----

--pMz4EgqzcDuo/M/K--