Date: Wed, 25 Mar 2026 10:33:48 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>,
	shihao zhong <zhong950419@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple
 relations
Message-ID: <acQAXPXov4cbyUx0@nathan>
References: <aFn82kXgvwKHncs-@paquier.xyz>
 <aFrSlSz9fi47j5Sr@nathan>
 <aFtRd1Q4QuCWcg5k@paquier.xyz>
 <aFwT31Rw-Oj-bgO9@nathan>
 <aGIzjYsRrMCEADc5@paquier.xyz>
 <rzxpxod4c4la62yvutyrvgoyilrl2fx55djaf2suidy7np5m6c@3l2ln476eadh>
 <ab2iXwhRe3fFNPfp@nathan>
 <aglpy2jbnb75vufdx6hqkgokquzmoshcbnuxlcxhum4k7tyi7m@27m4hbxo2u2g>
 <acMGcoUwA9CiPPU1@nathan>
 <loig4i4hc4vuybn6uv6e2kgqm37sebbzujkrvdf6uhbxq5dsfm@7wbkmucts3eu>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="dBKjKIhnmUwGVOll"
Content-Disposition: inline
In-Reply-To: <loig4i4hc4vuybn6uv6e2kgqm37sebbzujkrvdf6uhbxq5dsfm@7wbkmucts3eu>
Archived-At: <https://www.postgresql.org/message-id/acQAXPXov4cbyUx0%40nathan>
Precedence: bulk


--dBKjKIhnmUwGVOll
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 24, 2026 at 11:29:52PM -0400, Andres Freund wrote:
> On 2026-03-24 16:47:30 -0500, Nathan Bossart wrote:
>> +	VacuumParams params_copy;
> 
> I'd maybe not name it _copy, but params_local or params_table or such, as
> somehow it seems a bit odd to modify the copy. But I can't really explain why
> it feels odd.

params_local WFM.

> I wonder if more of the code in the function should be updated to use the
> copy, otherwise it seems like it could more easily happen that a part of the
> code not using the modified version is moved until after a modification, and
> the code author assumes the modifications now have taken effect.

Yeah, I was waffling on this.  I updated the rest of the function to use
params_local instead.

-- 
nathan

--dBKjKIhnmUwGVOll
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v2-0001-avoid-including-vacuum.h-in-tableam.h-and-heapam..patch