Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 26 Mar 2026 08:26:26 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Yugo Nagata <nagata@sraoss.co.jp>,
	Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Track skipped tables during autovacuum and autoanalyze
Message-ID: <acRvIt2idOKeD7wv@paquier.xyz>
References: <20260324151133.7940a5c1f2ebd594d54da481@sraoss.co.jp>
 <CAA5RZ0snnePNW1NKGKh+NyJ1CY26T5F_6-tTq+BHWM2kj1fN1g@mail.gmail.com>
 <20260325012847.e026ba1860c07288efe3e97d@sraoss.co.jp>
 <acNDTM20nJjDYZxq@paquier.xyz>
 <20260325132451.807ebb159f3b11e88ad4ecc0@sraoss.co.jp>
 <CAA5RZ0v=tdz3nGgq-Sk7hEwac1P=5J7d+SXd+62azfqiogdG6w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="WkakBkjbT7IZF2eo"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0v=tdz3nGgq-Sk7hEwac1P=5J7d+SXd+62azfqiogdG6w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/acRvIt2idOKeD7wv%40paquier.xyz>
Precedence: bulk


--WkakBkjbT7IZF2eo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 25, 2026 at 12:12:35PM -0500, Sami Imseih wrote:
> I'm fine with adding timestamps, as there seem to be convincing
> reasons to add them.
> My other concern is bloat of the pg_stat_all_tables view. This patch
> adds 4 columns, or
> 8 if we also include manual vacuum and analyze (which I think we should).
>=20
> Given that, should we also start thinking about splitting the vacuum
> activity related
> columns into a dedicated view and out of pg_stat_all_tables for v20?

PgStat_StatTabEntry is shared between indexes and tables.  A bunch of
its fields apply only to tables, not indexes (aka all the vacuum and
analyze ones).  Few fields apply only to indexes, not tables.  Not
that many are shared between both.  I would advocate for a clean split
between indexes and tables, as a start, with a new variable-sized
stats kind dedicated to indexes.
--
Michael

--WkakBkjbT7IZF2eo
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnEbyIACgkQnvQgOdby
QH2YKg//fVCLycHSlSRUdJwK3M6Kv1VuHfIj3yoi/l+gqymXXq3eToCz5jj9+Lpi
zdglDX3kgkJRkxzv19zEBOOfUjC79Kx6kzW0woEntK7dGYd16O1nvlKeIj0Rh07A
y22hbEfitzZNQRqf5IB57SKLpzM4eM4A4rKzsykexq9mkKEeH4dvd4UJvuFB0QWt
ZdNQaD0oJRVZVDItGj5jRMRw3hbmG6yJXRjWe1ej0JVRspy5P8OJcdY+y5kIhTuY
ogeRrKjaStovCD3cAy9yEQZMwQ7+5iZgke+wLIRWKLL5J7D5GZ5e9XCg4HzocHWc
/wFNe0ajWLfZTip/NwQvvYqfRmj9Lm2nlK/GJ4R7qa0K2IaxiGgOXisbeKWpv6Ol
8WJmyyEKTN9cugSBuU6e3oaru9Fv4QHYt8kpL0Nbs7UTQ2emdpnd2E181SOrNEvL
zcxD4EQ3vOBqT6SA5Wl+13Dz68dFkNaIfq3V7PrKB8Mq0tLGsVP/zgSQ0ohu+yjL
8kk+fhHx5i3QxKRtEMw1ZcMwKQ1O0nsgX4y5HyUcGJFjgLteyZ8+a6JHUF9kPy6M
Bj4WmqgR3PqF3U1FwpGQeisPFEQVCUWvbfh7DDCgrH9BCQGhttRnTTacLaYgsmQS
eUgzk57D+M6/eLW0gZOscPIDaaNokxAl8Uvfdsv+ztnnqHZotgQ=
=y3C4
-----END PGP SIGNATURE-----

--WkakBkjbT7IZF2eo--