Date: Thu, 26 Mar 2026 04:05:40 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Jeff Davis <pgsql@j-davis.com>,
	Greg Sabino Mullane <htamfids@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Adding locks statistics
Message-ID: <acSwlC46/WhYZuy5@ip-10-97-1-34.eu-west-3.compute.internal>
References: <abufUya2oK-_PJ3E@paquier.xyz>
 <abvrRZo52Yx9ZzWQ@ip-10-97-1-34.eu-west-3.compute.internal>
 <ab4y1UQUsSS7bSVd@paquier.xyz>
 <acI3H5aucJNS2w78@paquier.xyz>
 <hlkdrplgrmudbspibsuq6xooxrqxqsgwo6x5b6x5ptvkgjbe7w@xogt6xgua6dz>
 <acMiT69EEGKHWGM5@paquier.xyz>
 <acNTR1lLHwQJ0o+P@ip-10-97-1-34.eu-west-3.compute.internal>
 <acNxrWn2bvDARnC3@paquier.xyz>
 <acQ9gnE84897xHfQ@ip-10-97-1-34.eu-west-3.compute.internal>
 <acRqbLtT-aJDRSRl@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="xXiKR5PTcrB7/XYd"
Content-Disposition: inline
In-Reply-To: <acRqbLtT-aJDRSRl@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/acSwlC46/WhYZuy5%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk


--xXiKR5PTcrB7/XYd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

On Thu, Mar 26, 2026 at 08:06:20AM +0900, Michael Paquier wrote:
> 
> I like the patch, but I happen to not like my initial idea of relying
> on a NOTICE in an injection point combined with your new API in
> BackgroundPsql because we can already achieve the same with a wait
> injection point and use BackgroundPsql::query_until() with an \echo to
> detect that the command is blocked.

Yeah that works too.

> The updated version attached uses this method (edited quickly your
> commit message).  Like your patch there is no need for hardcoded
> sleeps and the CI's first impressions are actually good,

Same here.

> but I am
> going to need more runs to gain more confidence.  Note I should be
> able to do something here in 10 days or so.  If you could confirm the
> stability on your side for the time being with more runs, that would
> help, of course.

With wait + echo we don't need s2 to "on_error_stop => 0" anymore. I changed
that in the attached. I'll run more CI tests during those 10 days. Let's sync
up when you'll be about to push it.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

--xXiKR5PTcrB7/XYd
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v3-0001-Add-tests-for-lock-stats-take-two.patch"