Date: Thu, 26 Mar 2026 11:07:52 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>,
	shihao zhong <zhong950419@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple
 relations
Message-ID: <acVZ2O0938nWa73w@nathan>
References: <aFtRd1Q4QuCWcg5k@paquier.xyz>
 <aFwT31Rw-Oj-bgO9@nathan>
 <aGIzjYsRrMCEADc5@paquier.xyz>
 <rzxpxod4c4la62yvutyrvgoyilrl2fx55djaf2suidy7np5m6c@3l2ln476eadh>
 <ab2iXwhRe3fFNPfp@nathan>
 <aglpy2jbnb75vufdx6hqkgokquzmoshcbnuxlcxhum4k7tyi7m@27m4hbxo2u2g>
 <acMGcoUwA9CiPPU1@nathan>
 <loig4i4hc4vuybn6uv6e2kgqm37sebbzujkrvdf6uhbxq5dsfm@7wbkmucts3eu>
 <acQAXPXov4cbyUx0@nathan>
 <acSYYcbfDk0bSgGq@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="Ca6sfZgjkQSqww2W"
Content-Disposition: inline
In-Reply-To: <acSYYcbfDk0bSgGq@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/acVZ2O0938nWa73w%40nathan>
Precedence: bulk


--Ca6sfZgjkQSqww2W
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 26, 2026 at 11:22:25AM +0900, Michael Paquier wrote:
> Once vacuum_rel() has its VacuumParams changed to a pointer, renaming
> it to params_local and use params_local in all its code paths looks
> sensible.  On top of what you are doing, I would add a big warning
> comment at the top of the routine to mention that "params" should not
> be used directly in the routine.  The local copies should be used.

Wait...  Can't we just pass params by value only to vacuum_rel()?  Doesn't
this accomplish what we need?

-- 
nathan

--Ca6sfZgjkQSqww2W
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v3-0001-avoid-including-vacuum.h-in-tableam.h-and-heapam..patch