Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 27 Mar 2026 08:03:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
	shihao zhong <zhong950419@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple
 relations
Message-ID: <acW7Qg1fjPeaKqeF@paquier.xyz>
References: <aFwT31Rw-Oj-bgO9@nathan>
 <aGIzjYsRrMCEADc5@paquier.xyz>
 <rzxpxod4c4la62yvutyrvgoyilrl2fx55djaf2suidy7np5m6c@3l2ln476eadh>
 <ab2iXwhRe3fFNPfp@nathan>
 <aglpy2jbnb75vufdx6hqkgokquzmoshcbnuxlcxhum4k7tyi7m@27m4hbxo2u2g>
 <acMGcoUwA9CiPPU1@nathan>
 <loig4i4hc4vuybn6uv6e2kgqm37sebbzujkrvdf6uhbxq5dsfm@7wbkmucts3eu>
 <acQAXPXov4cbyUx0@nathan>
 <acSYYcbfDk0bSgGq@paquier.xyz>
 <acVZ2O0938nWa73w@nathan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MPrbLaEL0hr28ZXS"
Content-Disposition: inline
In-Reply-To: <acVZ2O0938nWa73w@nathan>
Archived-At: 
 <https://www.postgresql.org/message-id/acW7Qg1fjPeaKqeF%40paquier.xyz>
Precedence: bulk


--MPrbLaEL0hr28ZXS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 26, 2026 at 11:07:52AM -0500, Nathan Bossart wrote:
> Wait...  Can't we just pass params by value only to vacuum_rel()?  Doesn't
> this accomplish what we need?

It would accomplish Andres's goal of avoiding a deeper inclusion of
vacuum.h in src/include/.

Still, I slightly prefer your v2, where the interface of vacuum_rel()
is leaner with all the other ones.  It comes at the cost of copying
the input parameters into a temporary "copy" of VacuumParams, but I
see the fact of marking the input "params" with a const as more
valuable in the long-run, with less temptation to manipulate it
directly especially it is not not marked with a const.  One small
worry with v3 is that people like copy-pasting code around, and I
suspect that v2 could discourage better the patterns that 2252fcd4276c
has tried to improve and that 661643dedad9 had to fix.
--
Michael

--MPrbLaEL0hr28ZXS
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnFu0IACgkQnvQgOdby
QH2+VhAAlDjpZlPE1fnQ/4QZYJ8BsgPrgfDDSepNQnZwpTZRH1cYS30YCwrftp7Z
VH9GZnI+g0q2kt6tUlLKLw5f1WbN8VU/k53GXnT0/RidHgIaxAxfyNlmX8bnMoK5
nbwve2QjGPklSUJk84YPMrHKYVShWBDX/aiHxS497ZqpALsZy3TnN6qz8g9nSAku
bvnYsJWeSrZNmW11UVc8OVcmFPs7M/Br6FmkVAR8yNx4b1BcFKcXKKc6v2ssLm5O
fpoCucaLhVUo3IYMEcnZfat7KO5N1luSg8OsJQHCtihQPOZ+amU6N+EN33PdPwJg
xBkwxXCdYSaxev3aVhyZrKoG+v0tVaLmuQ4w34yieLbEtdUlzVrK/hJgcXJHflG6
1JmBcjeubjNYCuDj+G3QtQvYATHfLxgkdw5xZqpRunQVKQr2g0rFc6l95dBqCiAZ
gW5qmqY4heeebWKAhbz8Juorne8OadSWY/0+BvC9JQrHUxMUl8CaeZM87H3XpDEH
h5XRx0+qefoJR1xJTke6tEPOAgoWE679C3P9GepAvkDSuqKcPoRJqRhEYei+vXXr
XOXEXYnX6XpoImUg91zSg13qc50NBAS2ravTPbbTBB8Tix6uVFD1Obc7iGIMLj7G
nE5nVnikG36M0aUdQto6X3KBEqaxEFipC7Fh3L66yBy9dt/9ReY=
=U7O/
-----END PGP SIGNATURE-----

--MPrbLaEL0hr28ZXS--