Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 27 Mar 2026 08:07:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Yugo Nagata <nagata@sraoss.co.jp>
Cc: Sami Imseih <samimseih@gmail.com>,
	Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Track skipped tables during autovacuum and autoanalyze
Message-ID: <acW8MW-Gb8Aj_TH2@paquier.xyz>
References: <20260324151133.7940a5c1f2ebd594d54da481@sraoss.co.jp>
 <CAA5RZ0snnePNW1NKGKh+NyJ1CY26T5F_6-tTq+BHWM2kj1fN1g@mail.gmail.com>
 <20260325012847.e026ba1860c07288efe3e97d@sraoss.co.jp>
 <20260326192203.e6dbb8d80f8d27dc15ceee59@sraoss.co.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="1/Rqlj3ohlLYjYho"
Content-Disposition: inline
In-Reply-To: <20260326192203.e6dbb8d80f8d27dc15ceee59@sraoss.co.jp>
Archived-At: 
 <https://www.postgresql.org/message-id/acW8MW-Gb8Aj_TH2%40paquier.xyz>
Precedence: bulk


--1/Rqlj3ohlLYjYho
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 26, 2026 at 07:22:03PM +0900, Yugo Nagata wrote:
> To handle the possibility that the table is dropped between
> RangeVarGetRelid() and the lock attempt, SearchSysCacheExists1() is
> used after acquiring the lock.

(Noticed while skimming through my emails this morning..)

+void
+pgstat_report_skipped_vacuum_analyze(Oid relid, bool vacuum, bool analyze,
+                                     bool autovacuum)

I'd recommend to replace this interface with three booleans with a set
of three bitwise flags.  That would be less error prone for the
callers of this function, or we could finish by aggregating counters
we don't want to.
--
Michael

--1/Rqlj3ohlLYjYho
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnFvDEACgkQnvQgOdby
QH167Q/9EBjoGXCS50oQu/BOCT3FeGf0DwoNf4Hc7myC1OmYB7orDqLXrDgSrB6t
8p0F6TKuaG8iz5HgDgfZH6sYIannQyDSXQWgi4++VVGIdTlfq2K49n/muiKNhXUQ
OSH9SWTmd1DQnqqBBCdIeii7SuevfHIDNltxY3AjcLGSv31wqjaH2QhC09MOX2yH
a9T11Pk1R5HfgjLvuUxQCXK0/j5Tt+pDGnqKfgD7sFhbaGxOf5+ksM86fcpxcxVK
g4LcHDMeQH4OXuDp4ztKFIx0Zcz/CpQXcI19ExRP4p/tzWoFX8Hrgrafej6FIljl
OIeYc0ETXfD+DSZ1Zgt3g596P8e09CMhsmKU+8CW5TvifcuIOPlZdtpmJ4nMT53o
w78sjAm3F6g/ilLFSExgaxpxrmTG9Lt82MElh99KqmvBtXfJg+EbfYVicBsJ5GqU
MvP/7U+vUTJaJxdZOfO10tEt5S2GVeT+TD045AFBiJOuxMaMPsCx3JciEc+x5bWH
5WqQL6JWNxDWmGuC+jX2kxkdgbVzOPbDK80TMwx6vnW8II1qeQemNhKzB2ShGWQZ
UUwYheyw7GHfCOO/TqV04eIbroxGti+c9mIl5Mtu29yKsz6mfsaZSe4yAYhLPQUj
PZDd1VS0A5QnWr9gRGEVc86dJrqLEXCd36eYkgC1XphFTmiMEro=
=5281
-----END PGP SIGNATURE-----

--1/Rqlj3ohlLYjYho--