Date: Thu, 26 Mar 2026 14:30:37 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Rename LWLockNewTrancheId() parameter from "name" to
 "tranche_name"
Message-ID: <acWJXUQVYExHC063@nathan>
References: 
 <CAA5RZ0tpJ8GBrWshkUJ29Fu3juqgdbr=kfK3O9FMLrEy1zPOkg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0tpJ8GBrWshkUJ29Fu3juqgdbr=kfK3O9FMLrEy1zPOkg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/acWJXUQVYExHC063%40nathan>
Precedence: bulk

On Thu, Mar 26, 2026 at 01:34:38PM -0500, Sami Imseih wrote:
> While looking at something nearby, I noticed a naming inconsistency for
> the parameter name in LWLockNewTrancheId(). It should be tranche_name,
> similar to RequestNamedLWLockTranche(), and in other places it's
> referenced in the docs/comments.

I don't mind changing it, but I don't find "tranche_name" to be
substantially better than "name" in this case.  Maybe it's a little
clearer, but there's not much room for confusion here.

-- 
nathan