Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 27 Mar 2026 08:23:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: John Naylor <johncnaylorls@gmail.com>
Cc: Yugo Nagata <nagata@sraoss.co.jp>,
	Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Adjust error message for CREATE STATISTICS to account for
 expressions
Message-ID: <acXAAbIp9tfsvHxy@paquier.xyz>
References: <20260324203430.411331c59ca462457ec0aa8b@sraoss.co.jp>
 <CANWCAZYdyQzCoAiq9kybHT2RcnC1CgrxbCpyxeV3+KZn2xj2UA@mail.gmail.com>
 <20260325131548.4c9a0c8d05a422021b1ba76c@sraoss.co.jp>
 <CANWCAZYjDSsvC6M6pas26ffbj-TZmXOHHC1-DwRM2LFa+qr3GQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="TnzbiLaQO01ldoGV"
Content-Disposition: inline
In-Reply-To: 
 <CANWCAZYjDSsvC6M6pas26ffbj-TZmXOHHC1-DwRM2LFa+qr3GQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/acXAAbIp9tfsvHxy%40paquier.xyz>
Precedence: bulk


--TnzbiLaQO01ldoGV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 26, 2026 at 04:22:07PM +0700, John Naylor wrote:
> I'd probably write this as "extended statistics on a single column are
> not supported" (no need to send a new patch).
>=20
> Any objections?

None.  I have found this error message puzzling while doing some of my
recent work for extended statistics, because extended statistics can
be created if there is a single element made of an expression in the
list given in input.

> Also, I'm leaning towards not backpatching -- I figure a user that got
> here by fat-fingering an expression is not likely to be too confused.

-    errmsg("extended statistics require at least 2 columns")));
+    errmsg("extended statistics are not supported on a single column")));

Now our documentation also tells that the former message is not the
preferred project style (full sentences usually avoided in primary
messages):
https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-STYLE-GU=
IDE-GRAMMAR-PUNCTUATION

Perhaps something like "could not create extended statistics" with a
hint describing the cause would be better..  Full sentences usually
apply to errdetails or errhints.  If we're on it, we could just as
well improve the whole thing, I guess?
--
Michael

--TnzbiLaQO01ldoGV
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnFwAEACgkQnvQgOdby
QH1UYw//SQyXw67JapMuBo33oiyuk3DKCAKkXCADNCA2XO0OyrlWbf8L2iP2IJgh
LcORhAFc4SRAuWirPccFQ8BPu6+5oPFqyjKVrl+76lN/80anCW/38bb7TocTrfmK
3+I/rxhw1hZXHjszzPhtaCS5I8Ba5RQumE8b2VjL/BAPb+EWM2AWXWSd97DnhTgB
YLNfOeyqposJbPUb9RDUBDaXvTj379P0YMByTO5jQqWgH+ATv8Je9UJaaCXZglb1
jWqAKrR/YiKecQ9sBU35PEOgU78lqnqrbU0LwcWEQb5ScLObD2dw7fWvcuD98oBZ
EBd51A/624fT60mHA9I6ILg6SCiMKFuBP87Yda6aXZs10tHK8KkzmRMeyDMnIaCm
L3tvMtv1a81AvdGofQBnG5lFls6FXSWjW0rmIqktrsAoyL0cEubMKEBSJQvy26rW
JjUw1UzjKooO6Gikkfhe53KGUDQuta1RmqAcSt8Sc/kzXf96amG9ZUWxh0hENVwS
PHnAzSeKah34dQextjm4t1jgqY2XIfcwrhnHT3iFDKZPhacge1LxyTdkBjulKVeu
vDNRLB4fvpq9xkKO+jK2VCxFDcflXiDcHfKpEC6jlUUpNJbqq+QeFn+rd/vkOo3k
g92QPXOM8gldkHSKRsed5A8cV9/tZAKnjUMdjZW0eyO4tmazLY8=
=QbRq
-----END PGP SIGNATURE-----

--TnzbiLaQO01ldoGV--