Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 27 Mar 2026 08:32:52 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>, Sami Imseih <samimseih@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Thomas Munro <thomas.munro@gmail.com>
Subject: Re: dshash_find_or_insert vs. OOM
Message-ID: <acXCJODjsCytdpwT@paquier.xyz>
References: 
 <CA+TgmoaJwUukUZGu7_yL74oMTQQz2=zqucMhF9+9xBmSC5us1w@mail.gmail.com>
 <CAA5RZ0vNVdBnm_TSCR5K6fT7yc7-jQuneNUYFxFgS7hQnn62sA@mail.gmail.com>
 <CA+TgmoZ3cd+wh1vz8gB_iD9zxZX558xUERaPm7G-M8wa7p9GNg@mail.gmail.com>
 <CAA5RZ0tWjsthTod0ODPEW4noNrSvY+gRWTMxiQ89-yY-k92B8Q@mail.gmail.com>
 <CAA5RZ0uhz2uEtUV1KqoCHKQY4U3pgB6N1n-oR-gy8TPUoenQSA@mail.gmail.com>
 <CA+TgmoYmzRbNjx8sbm_0Hk-VtLBtJPe=juOUSFkm7ge4Xy7hYw@mail.gmail.com>
 <gq55lyolnqm4yv7texawu7sr64btcczktu7hd4byl6zarxkibv@pb6ajailtqop>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="n8oHdY69QRSVzQ1U"
Content-Disposition: inline
In-Reply-To: <gq55lyolnqm4yv7texawu7sr64btcczktu7hd4byl6zarxkibv@pb6ajailtqop>
Archived-At: 
 <https://www.postgresql.org/message-id/acXCJODjsCytdpwT%40paquier.xyz>
Precedence: bulk


--n8oHdY69QRSVzQ1U
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 26, 2026 at 04:26:33PM -0400, Andres Freund wrote:
> I think tests like this do have value and I'd definitely run them first while
> hacking on code related to dshash, rather than relying on the regression tests
> or such.  E.g. having test_aio was invaluable to being able to get AIO into a
> stable state.  When hacking on something with complicated edge cases I'd just
> add a test for it, making development faster as well as ensuring the
> complicated case continues to work into the future.

These test modules have a lot of value because they are cheap to run
and are very usually able to reproduce edge cases that no other place
of the code tree would be able to reach in a predictible way.  Cheap,
fast and reliable is good.  On top of that they can serve as code
template.  Bonus points.

> However, creating its own test module for small parts of the codebase doesn't
> quite make sense to me. A pretty decent chunk of the test is just boilerplate
> to add a new module, and every new test module requires its own cluster, which
> adds a fair bit of runtime overhead, particularly on windows.  I think
> test_dsa, test_dsm_registry, test_dshash should just be one combined test
> module, they're testing quite closely related code.

Yeah, perhaps grouping all the DSA things into a single module would
be OK, with a parallel schedule that would speed up things.  It
depends on the complexity and the size of the module to me.

Saying that, I think that the shape of the proposed test_dshash is
wrong: it proposes one SQL function that does a bunch of
dshash-related operations in a single function call, in a random
manner.  We have a shared memory state that can survive across SQL
calls, making it a set of thinner SQL function that wrap directly
dshash calls able to manipulate the table would feel much more natural
to me.  And it would be easier to design edge cases in the SQL
scripts themselves.
--
Michael

--n8oHdY69QRSVzQ1U
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnFwiQACgkQnvQgOdby
QH0Q3hAAjP2x2z5LxHTuBwlCV4a9VCsGkMqRMGfnV2lIFHpoEZpZULcTNxgzxHSW
/s0FxWOmNGd8qrbAR9x9OJHEaugR9ZJpHa80cK7S69XvXSrWzF88UMPWpv4nD+H+
t3qqakBGcrZ9VzNqc4pBcf5amWngfJL9AWS7I5pA0EeG4f4qZdKXlRilgt6aJerH
1nSPRmRF6/IQXm1JRgg5MZfRRd7l/0OC5XP5mFvN6qzMDQPcA87aJ5HMqC7pVs9l
75TCfLcsfmF4OMiiv8bbgMHcnUWdO37LsPPL1bA82XKshRRHW2gE6x+SFIu5gPy4
64Z12ldmWisjAlwgETZo5rwvjWfgF7p4ZtZpwBwSHukgBhx2RoHcyx9hSJv7PXoW
5aPVaLfAiyvp9qdtXlYUSjTbXOOzPbXArXOMxiRoicJqV9U84fqdeFZHeZn+Hgm7
NYhEYKCMNOFCHLsRuSqqXqGSXmuSh4nRHuMIKrwuDQKk4PYEXjrlYnVdY0rIlBB3
C+fg4czlrNvssVSddkpJqaWHIwehy73d9WQYLRhXJDqSoIL1YypR1CK3JkvYRBQ0
FSMbllzDr0HhKlGymqEXB3kJXz6rM0MU4/eK7jmfVC8OWmbwWBCZeNTPnW1QqSBc
Egw/6N3CBzCSkTATrIOArChZhFqt4n020bCeaoHN8tKFILzm0js=
=nvq7
-----END PGP SIGNATURE-----

--n8oHdY69QRSVzQ1U--