Subject: Re: Add support for automatically updating Unicode derived files
To: John Naylor <john.naylor@2ndquadrant.com>
References: <c8d05f42-443e-6c23-819b-05b31759a37c@2ndquadrant.com>
 <CACPNZCv2jmjpqkatr-NBJ8wpP6trY8MPBbW8nhqi--hL-0+dgQ@mail.gmail.com>
 <ff2f8e99-ac2b-1940-81c5-8b2fd1e674e7@2ndquadrant.com>
 <CACPNZCujxKdKFOm89iA8wzzYwZe-b6fHLWNGcix7WaCsYKa6uA@mail.gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <acc8396a-4e06-e5d4-6d42-f710eef11ede@2ndquadrant.com>
Date: Thu, 9 Jan 2020 10:16:19 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: 
 <CACPNZCujxKdKFOm89iA8wzzYwZe-b6fHLWNGcix7WaCsYKa6uA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-01-03 15:13, John Naylor wrote:
> On Thu, Dec 26, 2019 at 12:39 PM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>>
>> On 2019-12-19 23:48, John Naylor wrote:
>>> I would print out the full boilerplate like for other generated headers.
>>
>> Hmm, you are probably comparing with
>> src/common/unicode/generate-unicode_norm_table.pl, but other file
>> generating scripts around the tree print out a small header in the style
>> that I have.  I'd rather adjust the output of
>> generate-unicode_norm_table.pl to match those.  (It's also not quite
>> correct to make copyright claims about automatically generated output.)
> 
> Hmm, the scripts I'm most familiar with have full headers. Your point
> about copyright makes sense, and using smaller file headers would aid
> readability of the scripts, but I also see how others may feel
> differently.
> 
> v2 looks good to me, marked ready for committer.

Committed, thanks.

I have added a little tweak so that it works also without --with-python, 
to avoid gratuitous annoyances.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services