MIME-Version: 1.0
Date: Mon, 27 Mar 2023 13:28:24 +0300
From: Alexander Pyhalov <a.pyhalov@postgrespro.ru>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>,
 pgsql-hackers@lists.postgresql.org, Masahiko Sawada <sawada.mshk@gmail.com>,
 Michael Paquier <michael@paquier.xyz>, =?UTF-8?Q?=E6=9D=8E=E6=9D=B0=28?=
 =?UTF-8?Q?=E6=85=8E=E8=BF=BD=29?= <adger.lj@alibaba-inc.com>,
 =?UTF-8?Q?=E6=9B=BE=E6=96=87=E6=97=8C=28=E4=B9=89=E4=BB=8E=29?=
 <wenjing.zwj@alibaba-inc.com>, Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: CREATE INDEX CONCURRENTLY on partitioned index
In-Reply-To: <ZCBb7flZBr4wtKlK@telsasoft.com>
References: <CAD21AoCHYE5=PU7kJGGUHZuYVrHTHqmpUxN+8-rLGYpdgPwJ9g@mail.gmail.com>
 <20210128143013.GC7450@telsasoft.com>
 <be8ff634-72c6-3fc7-9175-5a6b974af4a9@postgrespro.ru>
 <20210226182019.GU20769@telsasoft.com>
 <04657227cc37b6353cf0c72bedac70cc@postgrespro.ru>
 <20220628183309.GD28130@telsasoft.com>
 <bec008ae632d54b3d81af2ca86419732@postgrespro.ru>
 <20221121030011.GU11463@telsasoft.com>
 <5bafee07d0e1b3ce5359d1656c90b4836d7cb6a1.camel@gmail.com>
 <20221204190935.GD14156@telsasoft.com> <ZCBb7flZBr4wtKlK@telsasoft.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <acd31119ede945f8092ba4faac5e1fb6@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/acd31119ede945f8092ba4faac5e1fb6%40postgrespro.ru>
Precedence: bulk

Justin Pryzby писал 2023-03-26 17:51:
> On Sun, Dec 04, 2022 at 01:09:35PM -0600, Justin Pryzby wrote:
>> This currently handles partitions with a loop around the whole CIC
>> implementation, which means that things like WaitForLockers() happen
>> once for each index, the same as REINDEX CONCURRENTLY on a partitioned
>> table.  Contrast that with ReindexRelationConcurrently(), which 
>> handles
>> all the indexes on a table in one pass by looping around indexes 
>> within
>> each phase.
> 
> Rebased over the progress reporting fix (27f5c712b).
> 
> I added a list of (intermediate) partitioned tables, rather than 
> looping
> over the list of inheritors again, to save calling rel_get_relkind().
> 
> I think this patch is done.

Hi.

Overall looks good to me. However, I think that using 'partitioned' as 
list of partitioned index oids in DefineIndex() is a bit misleading - 
we've just used it as boolean, specifying if we are dealing with a 
partitioned relation.

-- 
Best regards,
Alexander Pyhalov,
Postgres Professional