Message-ID: <acd8ab2e5b313e7dd8942cc24eb738950d6589f2.camel@j-davis.com>
Subject: Re: Remaining dependency on setlocale()
From: Jeff Davis <pgsql@j-davis.com>
To: Andreas Karlsson <andreas@proxel.se>, Joe Conway <mail@joeconway.com>,
	Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: Fri, 09 Aug 2024 11:24:03 -0700
In-Reply-To: <fc61c88f-ab78-4870-ada6-e915e9dc7a19@proxel.se>
References: <4c5da86af36a0d5e430eee3f60ce5e06f1b5cd34.camel@j-davis.com>
	 <1841102.1722982989@sss.pgh.pa.us>
	 <CA+hUKGK7qKDHgoh1HuvMhtcpAwwVBA5BDt33vCzYYqCLfQTtzw@mail.gmail.com>
	 <5b169990d1f602c3aa778a27f8516032ed899c99.camel@j-davis.com>
	 <57a3f214-41bc-4954-ac09-8eae039137e8@joeconway.com>
	 <45fcc802c66fdf52f4420b8cbe09e4fe26cd84fe.camel@j-davis.com>
	 <fc61c88f-ab78-4870-ada6-e915e9dc7a19@proxel.se>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/acd8ab2e5b313e7dd8942cc24eb738950d6589f2.camel%40j-davis.com>
Precedence: bulk

On Fri, 2024-08-09 at 13:41 +0200, Andreas Karlsson wrote:
> I am leaning towards that we should write our own pure ascii
> functions=20
> for this.

That makes sense for a lot of call sites, but it could cause breakage
if we aren't careful.

>  Since we do not support any non-ascii compatible encodings=20
> anyway I do not see the point in having locale support in most of
> these=20
> call-sites.

An ascii-compatible encoding just means that the code points in the
ascii range are represented as ascii. I'm not clear on whether code
points in the ascii range can return different results for things like
isspace(), but it sounds plausible -- toupper() can return different
results for 'i' in tr_TR.

Also, what about the values outside 128-255, which are still valid
input to isspace()?

Regards,
	Jeff Davis