Date: Sat, 28 Mar 2026 22:26:35 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	Akshay Joshi <akshay.joshi@enterprisedb.com>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] pgindent truncates last line of files missing a trailing
 newline
Message-ID: <aciN28vXRQVIWQzs@momjian.us>
References: 
 <CANxoLDfca8O5SkeDxB_j6SVNXd+pNKaDmVmEW+2yyicdU8fy0w@mail.gmail.com>
 <3bd49b59-7a87-4ab6-9eac-59b5d9cb78de@dunslane.net>
 <1133418.1771260634@sss.pgh.pa.us>
 <CAExHW5uSuG9qcGd=o6o6TiwWUKE4ie7K7nmgKzDzUKxrQ9rYDw@mail.gmail.com>
 <CANxoLDdbhQbap5vd3=01ad67EGbGNKDsvZdYVT3KRUiy-onYqA@mail.gmail.com>
 <1005500.1774542586@sss.pgh.pa.us>
 <c5ffe163-4758-4562-b3f6-6bfb00e58f49@dunslane.net>
 <1352724.1774639696@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1352724.1774639696@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aciN28vXRQVIWQzs%40momjian.us>
Precedence: bulk

On Fri, Mar 27, 2026 at 03:28:16PM -0400, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > On 2026-03-26 Th 12:29 PM, Tom Lane wrote:
> >> I'm not sure I want to expend the brain cells to figure out whether
> >> this is a correct/complete patch.  If pg_bsd_indent were less of an
> >> undercommented spaghetti-code nightmare, maybe fixing it here would
> >> be reasonable.  But as things stand, why don't we just fix this in
> >> the perl wrapper, as attached?
> 
> > Well, I thought we were trying to reduce the fixups we did in pgindent. 
> 
> Yeah, other things being equal I too would prefer to fix it within
> pg_bsd_indent.  But other things are not equal: the complexity
> and reviewability of the proposed v2 patch are not comparable to
> a one-liner fix in the wrapper.

I think the only way forward if we want to continue modifying
pg_bsd_indent is to rename most of the variables and add some sanity to
the code.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.