Date: Mon, 30 Mar 2026 12:00:01 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	Andres Freund <andres@anarazel.de>,
	=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: remove bits* types
Message-ID: <acqsERCb1t8OCZpG@nathan>
References: <absbX33E4eaA0Ity@nathan>
 <a3b5edc3-c0f5-42ae-b463-17018ee03dcb@eisentraut.org>
 <acV5NYm4XBzIE50N@nathan>
 <CAAKRu_ZucXL3mLc0f-t_7giiChN9Zad2EAr9SoAqFFc95vFaOg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="cfse7IKQXBjlvwxb"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAAKRu_ZucXL3mLc0f-t_7giiChN9Zad2EAr9SoAqFFc95vFaOg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/acqsERCb1t8OCZpG%40nathan>
Precedence: bulk


--cfse7IKQXBjlvwxb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Mon, Mar 30, 2026 at 12:41:09PM -0400, Melanie Plageman wrote:
> On Thu, Mar 26, 2026 at 2:21 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> On Wed, Mar 25, 2026 at 05:27:34PM +0100, Peter Eisentraut wrote:
>> > I'm mildly in favor of removing them.  But it appears there is no consensus.
>>
>> Same here.  While it still doesn't look like anybody is totally opposed to
>> the idea, you are right that there is no consensus.
> 
> I really wish we would remove them. I want fewer confusing typedefs in
> the code -- not more. I'm quite sad that as of 1bd6f22f43ac1b we are
> now using them more widely (and publicly), and I feel that was done
> without consensus. It should just use a regular uint32 -- like other
> places we do this (e.g. scan_begin() amongst many others).

Thanks for the heads-up.  Here's a rebased patch.

With Melanie's note, there are at least 4 votes in favor of this patch
(Andres, me, Peter, and Melanie).  AFAICT Michael is +/-0, Álvaro and Tom
are -1 (or somewhere in the vicinity), and Robert seems ambivalent.  Hm...

-- 
nathan

--cfse7IKQXBjlvwxb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=v2-0001-remove-bits-types.patch