Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 31 Mar 2026 08:52:46 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Lukas Fittl <lukas@fittl.com>, zengman <zengman@halodbtech.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Julien Rouhaud <rjuju123@gmail.com>
Subject: Re: Refactor query normalization into core query jumbling
Message-ID: <acsMzhxJ6lGbbel5@paquier.xyz>
References: 
 <CAA5RZ0ui6JSDPQDs2RW7eBDvrH_t_xg8bhUM8FaxawU8wDoMFg@mail.gmail.com>
 <8437F4D0-9DFB-4045-9318-CC3C5BA2E267@paquier.xyz>
 <CAP53Pkwb2f288Ji2s9ZZTL0_PEyYCZpQjBtD63X_s+yUB3YORA@mail.gmail.com>
 <CAA5RZ0vrXNndS6rGx43q+h9JNtxnUzZnxgP_zWSc9LHXS36bXg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="hBwvhcidlWe+Ao/0"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0vrXNndS6rGx43q+h9JNtxnUzZnxgP_zWSc9LHXS36bXg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/acsMzhxJ6lGbbel5%40paquier.xyz>
Precedence: bulk


--hBwvhcidlWe+Ao/0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 30, 2026 at 02:20:47PM -0500, Sami Imseih wrote:
>> I see where you're coming from on that, but I don't think we can
>> remove anything here in practice:
>=20
> Yes. Not unless we want to rely on the parser to track the lengths in
> Const, which could be invasive, but I have not looked into it.

Hmm.  We may not want to get down to that, still that would be
cheaper than reprocessing the parsing of the query string twice.=20

>> I still think it'd be reasonable for us to include
>> ComputeConstantLengths in core to complete the picture of what we're
>> doing with _jumbleElements and the length field already anyway. Its
>> basically a way to fully hydrate the partially filled out JumbleState
>> from the initial jumble.
>=20
> I fully agree, ComputeConstantLengths is an optional post-jumble-query st=
ep
> for a consumer that wishes to calculate the lengths. The length calculati=
on
> is not unique to a plug-in, so in my mind the work it's doing is core
> jumbling functionality.

Okay.  I could fall into that for this release.  Marking the
JumbleState as a const is the most important piece here.  I'm +-0
regarding this routine, but I can also see your point about how it's
useful to give at least the option to extensions to have a
recomputation of the Const lengths, the same way as PGSS.  What are
the extensions that would use that?
--
Michael

--hBwvhcidlWe+Ao/0
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnLDM0ACgkQnvQgOdby
QH3Wyg//UfkAUUQtXdE4bL4QuYPQdWUUwGqpIt7O3PjaH/U5DIO4TH/7qmGDjZdm
384izJWyfyoqiAejrVAtAPcZOFQLQPnR9w3+bkt0R2hQIfdc7gGC2B+PhEKTdsAv
CoiDWoQG2YUGWfu10m8dTGloMkvEreDFdDQbaZXsie2pGsMFn3izTlO2kHlBKEOu
8MwVhirHxu3f1SIkRz0zv8d4j98ZtgL8Qp31feXjZ3+YklLIMZ6KXTWT+R9LLSxu
jr/qrMYbXgNyfE0w14hKUjBoY+81OGL/B5vtGspbo7TrJw2ihT/4bwkdsrxiZt6k
NWIwT37OfO/mxRA8xFx3wk3FMi/qMY4z4f6Lvw1OKxrRBRKeMkDnLeD029nFokda
bz/AhNfnh50P1Mulkeo+OLNqIrBHqm4xxz7dtLhe4K9A/Ir1EYFPMaXhCk8j13Nc
36pEgBs/MEVGogRFxuE/W/jg3o9SnFkD0oQ755M9VTX2vYGtgXGnucfOH7Y/C/4U
bpYlYmNwHCjLIACWm/u9db1GdBirwfRbddp7Q5EUd+QFMUbcxT4OqAO2GA93YO6h
UkDVxkE/4yfT8WFAz+eHhDtcMB+ZNMhXiAuYq7iIzrQnx2tT6hDjXJiy0OuFqhS9
tihtNHD0pOe08+gpWL6YpM6AV8sJh+YazzXFDJ5X/y2KVJp0WpE=
=Z5E0
-----END PGP SIGNATURE-----

--hBwvhcidlWe+Ao/0--