Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1w7WBW-005Osv-0h
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 31 Mar 2026 10:18:58 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1w7WBT-009S5s-1q
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 31 Mar 2026 10:18:55 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <cb@df7cb.de>)
	id 1w7WBT-009S5k-0w
	for pgsql-hackers@lists.postgresql.org;
	Tue, 31 Mar 2026 10:18:55 +0000
Received: from goedel.df7cb.de ([49.13.90.212])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <cb@df7cb.de>)
	id 1w7WBR-00000001x1u-10W3
	for pgsql-hackers@lists.postgresql.org;
	Tue, 31 Mar 2026 10:18:54 +0000
Received: from msg.df7cb.de (unknown
 [IPv6:2a02:908:1472:9340:f0ad:fc6e:9c86:f1dc])
	by goedel.df7cb.de (Postfix) with ESMTPSA id 288D1126DF;
	Tue, 31 Mar 2026 10:18:50 +0000 (UTC)
Date: Tue, 31 Mar 2026 12:18:49 +0200
From: Christoph Berg <myon@debian.org>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org,
	Melanie Plageman <melanieplageman@gmail.com>
Subject: Re: pgsql: test_aio: Add basic tests for StartReadBuffers()
Message-ID: <acufieJk-t0euqJ1@msg.df7cb.de>
References: <E1w6G40-001l2v-2A@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1w6G40-001l2v-2A@gemulon.postgresql.org>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/acufieJk-t0euqJ1%40msg.df7cb.de>
Precedence: bulk

One of the AIO commits around this one (2026-03-28 00:00Z) broke the
postgresql-19 builds on apt.pg.o. Only the Debian unstable (sid,
assertions enabled) builds are working, everything else including the
nearly identical testing (forky) is broken (where assertions are off):

05:01:04 # +++ tap check in src/test/modules/test_aio +++
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, doesn't combine hits, block 0-1: expected stdout'
05:01:04 #   at t/001_aio.pl line 1474.
05:01:04 #                   '0|0|f|0
05:01:04 # 0|0|f|0'
05:01:04 #     doesn't match '(?^:^0\|0\|f\|1\n1\|1\|f\|1$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, doesn't combine hits, block 0-1: expected stderr'
05:01:04 #   at t/001_aio.pl line 1474.
05:01:04 #                   'psql:<stdin>:19: WARNING:  resource was not closed: [4728] (rel=base/5/16413, blockNum=0, flags=0x83000000, refcount=1 1)
05:01:04 # psql:<stdin>:19: WARNING:  resource was not closed: [4729] (rel=base/5/16413, blockNum=1, flags=0x83000000, refcount=1 1)'
05:01:04 #     doesn't match '(?^:^$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, interrupted by hit on 3, block 2-5: expected stdout'
05:01:04 #   at t/001_aio.pl line 1490.
05:01:04 #                   '0|2|t|1
05:01:04 # 1|3|f|0
05:01:04 # 1|3|t|2'
05:01:04 #     doesn't match '(?^:^0\|2\|t\|1\n1\|3\|f\|1\n2\|4\|t\|2$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, interrupted by hit on 3, block 2-5: expected stderr'
05:01:04 #   at t/001_aio.pl line 1490.
05:01:04 #                   'psql:<stdin>:27: WARNING:  resource was not closed: [4730] (rel=base/5/16413, blockNum=3, flags=0x83000000, refcount=1 1)'
05:01:04 #     doesn't match '(?^:^$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, hit, block 0: expected stdout'
05:01:04 #   at t/001_aio.pl line 1508.
05:01:04 #                   '0|0|f|0'
05:01:04 #     doesn't match '(?^:^0\|0\|f\|1$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, hit, block 0: expected stderr'
05:01:04 #   at t/001_aio.pl line 1508.
05:01:04 #                   'psql:<stdin>:39: WARNING:  resource was not closed: [4734] (rel=base/5/16413, blockNum=0, flags=0x83000000, refcount=1 1)'
05:01:04 #     doesn't match '(?^:^$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, hit, block 1: expected stdout'
05:01:04 #   at t/001_aio.pl line 1522.
05:01:04 #                   '0|1|f|0'
05:01:04 #     doesn't match '(?^:^0\|1\|f\|1$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, hit, block 1: expected stderr'
05:01:04 #   at t/001_aio.pl line 1522.
05:01:04 #                   'psql:<stdin>:47: WARNING:  resource was not closed: [4735] (rel=base/5/16413, blockNum=1, flags=0x83000000, refcount=1 1)'
05:01:04 #     doesn't match '(?^:^$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, hit, block 0-1: expected stdout'
05:01:04 #   at t/001_aio.pl line 1529.
05:01:04 #                   '0|0|f|0
05:01:04 # 0|0|f|0'
05:01:04 #     doesn't match '(?^:^0\|0\|f\|1\n1\|1\|f\|1$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, hit, block 0-1: expected stderr'
05:01:04 #   at t/001_aio.pl line 1529.
05:01:04 #                   'psql:<stdin>:51: WARNING:  resource was not closed: [4734] (rel=base/5/16413, blockNum=0, flags=0x83000000, refcount=1 1)
05:01:04 # psql:<stdin>:51: WARNING:  resource was not closed: [4735] (rel=base/5/16413, blockNum=1, flags=0x83000000, refcount=1 1)'
05:01:04 #     doesn't match '(?^:^$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, hit 0-1, miss 2: expected stdout'
05:01:04 #   at t/001_aio.pl line 1536.
05:01:04 #                   '0|0|f|0
05:01:04 # 0|0|f|0
05:01:04 # 0|0|t|1'
05:01:04 #     doesn't match '(?^:^0\|0\|f\|1\n1\|1\|f\|1\n2\|2\|t\|1$)'
05:01:04
05:01:04 #   Failed test 'worker: normal: read buffers, hit 0-1, miss 2: expected stderr'
05:01:04 #   at t/001_aio.pl line 1536.
05:01:04 #                   'psql:<stdin>:55: WARNING:  resource was not closed: [4734] (rel=base/5/16413, blockNum=0, flags=0x83000000, refcount=1 1)
05:01:04 # psql:<stdin>:55: WARNING:  resource was not closed: [4735] (rel=base/5/16413, blockNum=1, flags=0x83000000, refcount=1 1)'
05:01:04 #     doesn't match '(?^:^$)'
...

https://jengus.postgresql.org/view/Snapshot/job/postgresql-19-binaries-snapshot/
https://jengus.postgresql.org/view/Snapshot/job/postgresql-19-binaries-snapshot/781/architecture=amd64,distribution=forky/consoleFull

Christoph