Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGFRZ-0005D7-UR for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Jul 2023 09:02:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qGFRY-0000J0-PJ for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Jul 2023 09:02:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGFRY-0000Iq-GI for pgsql-hackers@lists.postgresql.org; Mon, 03 Jul 2023 09:02:00 +0000 Received: from meesny.iki.fi ([2001:67c:2b0:1c1::201]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qGFRW-001uy3-Kg for pgsql-hackers@lists.postgresql.org; Mon, 03 Jul 2023 09:01:59 +0000 Received: from [192.168.1.115] (dsl-hkibng22-54f8db-125.dhcp.inet.fi [84.248.219.125]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: hlinnaka) by meesny.iki.fi (Postfix) with ESMTPSA id 4Qvg0N1GDDzytx; Mon, 3 Jul 2023 12:01:56 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1688374916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ls7QdLCRoaKadI2GZtvozJMUEydfUF8npexovoUKO9c=; b=iJT9b3Ax6kLRgQyLiJ/Ez8eesCNgv4NTv5a2bwDmDoO1rvlX8CdxZ/oI9LBbbDn+6sbjBZ 1Dl7dkH7PwWIs5v+DlBJVl38uyTqImTtFurrh5rAExby+nKz0xWHct+ekClRv5OQv8CVLF /B4Jb/wPvkdu3Dcvxf4psSQef6VPTQ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1688374916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ls7QdLCRoaKadI2GZtvozJMUEydfUF8npexovoUKO9c=; b=pr6/UB01OcXJoehB8xsZiCryo4kfxznS+u388xo1NnDGRd8AmrFwRlUD9S5QEPIwUEP27B rZ0539ON55XHVTxW5jKNaxCsEZ7c3gRjcmc1PHNp85sAqoRQMk2B/aVvZ9keTAqY02u86h lvy3Gs044Pyzn0JSdvyfwC3LftlN1Lk= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1688374916; a=rsa-sha256; cv=none; b=wTyg/8r9Ek80lf2APcSLg6EiwlKzZkMULnZGjMmrzly7Y7P6C6Bt7+9AkQ94tZ5qNBiIft P4gOeSNFSi8iX4mX9CtQgiNTxrlj0jqvs9z7PisQx++/OSNoMtb1KKg4B7gBjTtDCjL/Bk ogDjKMXX340q64nMK3XHpAc2aKeyxbU= Message-ID: Date: Mon, 3 Jul 2023 12:01:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: Outdated description of PG_CACHE_LINE_SIZE Content-Language: en-US To: Julien Rouhaud , pgsql-hackers@lists.postgresql.org References: <20230701074936.p3qcssl4t7murt2q@jrouhaud> From: Heikki Linnakangas In-Reply-To: <20230701074936.p3qcssl4t7murt2q@jrouhaud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 01/07/2023 10:49, Julien Rouhaud wrote: > Hi, > > I just noticed that the comment for PG_CACHE_LINE_SIZE still says that "it's > currently used in xlog.c", which hasn't been true for quite some time. > > PFA a naive patch to make the description more generic. Applied, thanks! -- Heikki Linnakangas Neon (https://neon.tech)