Message-ID: <ad539fc6-2314-4582-aa5a-cb0eeb54998b@vondra.me>
Date: Wed, 19 Feb 2025 21:21:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Adjusting hash join memory limit to handle batch explosion
From: Tomas Vondra <tomas@vondra.me>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <7bed6c08-72a0-4ab9-a79c-e01fcdd0940f@vondra.me>
 <CAAKRu_bYZvc3gHa+PnE2BTwbu1xX3MgyG+99-MZh7Rg5QyOEEA@mail.gmail.com>
 <5a440920-4ca4-4bd0-8b42-a5aa7af4fb70@vondra.me>
 <CAAKRu_aBW=NKGPK=+d_Xc0uk2ci47x7uej3WGUjgQSRLdnFyqw@mail.gmail.com>
 <508fda6f-5a9d-42c9-af6e-aa94ed1210ec@vondra.me>
 <CAAKRu_YiLv24QKKJvUtDoO+=tw9Z5mt2i1g5=0992nmtwRekBQ@mail.gmail.com>
 <e8c65bf0-0008-40a5-8467-9b829464be0a@vondra.me>
 <5c6b1a65-6265-4bc5-9d0e-a4c7d6ff3d62@vondra.me>
 <04cc34f5-47ae-4ed7-b7b6-c6ba8bf2f8ae@vondra.me>
 <CAAKRu_Zu59jWM+WCWUyc_W8x6VQ1HqX7FGDhV2cJj07E_Li9ug@mail.gmail.com>
 <a8e27cd2-c2ec-475f-9830-5601b4aec2af@vondra.me>
 <310eeb10-1c75-4361-966a-33fa12970e6e@vondra.me>
Content-Language: en-US
In-Reply-To: <310eeb10-1c75-4361-966a-33fa12970e6e@vondra.me>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/ad539fc6-2314-4582-aa5a-cb0eeb54998b%40vondra.me>
Precedence: bulk

I've pushed the first (and main) part of the patch series, after some
more cleanup and comment polishing.

As explained in my previous message, I'm not sure about 0002. I don't
know if we need to worry about it (no reports AFAICS). And while the
patch works I'm not sure it's the best fix, or whether we need to do
something about exhausting hash bits.

In any case, it's not PG18 material. And it's a separate issue, so I'm
marking this as committed.


Thanks everyone who helped with any of the many old patch versions!


-- 
Tomas Vondra