Message-ID: <ad5d772e-09d9-4248-97a4-0011afab9e71@postgrespro.ru>
Date: Thu, 16 Jul 2026 17:34:54 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and
 -DEXEC_BACKEND at startup
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Michael Paquier <michael@paquier.xyz>, Euler Taveira <euler@eulerto.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <alew9Lk3BXiGZsm7@alvherre.pgsql>
Content-Language: en-US
From: Anton Voloshin <a.voloshin@postgrespro.ru>
In-Reply-To: <alew9Lk3BXiGZsm7@alvherre.pgsql>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/ad5d772e-09d9-4248-97a4-0011afab9e71%40postgrespro.ru>
Precedence: bulk

On 15/07/2026 19:14, Álvaro Herrera wrote:
>> Shouldn't this be extern *PGDLLIMPORT* bool ... ?
> 
> Did you hit a problem with it?  If so, what was it?

Not a problem per se, rather a small inconsistency.
Since commit
8ec569479fc Apply PGDLLIMPORT markings broadly. (2022-04-08) <Robert Haas>
it seems to be a rule to mark all variables in .h files as PGDLLIMPORT.
Perhaps, except frontend-only ones.

As for now,
$ find src/include -type f -print0 | xargs -0 src/tools/mark_pgdllimport.pl
src/include/common/logging.h: adding 1 PGDLLIMPORT markers
src/include/postmaster/syslogger.h: adding 1 PGDLLIMPORT markers

modifies only two lines in two files. And common/logging.h is a
frontend-only, so it's a natural exception. So I think there is no need
to add another exception without explicit reasons, even though you are
right and it's hard for me to think of a realistic need to refer to that
variable from an extension.

-- 
Anton Voloshin
https://postgrespro.com