Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 15 Apr 2026 01:05:38 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Haibo Yan <tristan.yim@gmail.com>, Mohamed ALi <moali.pg@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Fix: Partitioned parent index remains invalid after
 child indexes are repaired
Message-ID: <ad5l0sGiJwdkXI-L@paquier.xyz>
References: 
 <CAGnOmWqi1D9ycBgUeOGf6mOCd2Dcf=6sKhbf4sHLs5xAcKVCMQ@mail.gmail.com>
 <CABXr29GbJe7-vbm0Fn=HWx3vQonwFtv_zO1pSc5FZAvjLuUDVA@mail.gmail.com>
 <CABXr29Epj=23eYAWg_mTdiXYQQzJSVN22uk6tK8ei0ts5wXvSQ@mail.gmail.com>
 <CAA5RZ0s16eHrzcDupipAxC++e-p_n_M7Fpg-MG-V59fB=wykLw@mail.gmail.com>
 <ad1rubGPdHxNnDh5@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Px/GKJAInXPYn7yT"
Content-Disposition: inline
In-Reply-To: <ad1rubGPdHxNnDh5@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/ad5l0sGiJwdkXI-L%40paquier.xyz>
Precedence: bulk


--Px/GKJAInXPYn7yT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 14, 2026 at 07:18:33AM +0900, Michael Paquier wrote:
> On Sat, Apr 11, 2026 at 11:10:54AM -0500, Sami Imseih wrote:
>> Would the right solution here be to try to have the ATTACH PARTITION  ch=
eck if
>> the parent index is not valid, then validatePartitionedIndex() ?
>=20
> This may be a backpatchable thing, even if it requires one to detach
> one partition before attaching it again, or attach a fake partition to
> force a flip of the flag, before detaching this fake partition.

Actually no.  Yesterday I was looking at that from the angle of using
ALTER TABLE for the job, that requires a partition bound.  Sami has
mentioned me that a repeated ALTER INDEX .. ATTACH PARTITION does not
fail when repeated, so we could just rely on that and enforce a
round of indisvalid across the partitioned index we are working on.

Could you write a patch?  It would be better to have tests with
multiple levels, at least, with a partitioned table being a leaf of
another partitioned table.  I am sure you get the picture, the point
being to recurse across multiple levels.
--
Michael

--Px/GKJAInXPYn7yT
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmneZdIACgkQnvQgOdby
QH2SwQ//X+sms7UMmbLWLeps8eh+9yNqugmtQpqQCAHbxfGg/kkkKqJp7iIKbjCz
VnW5yW5lKh7docJBxgQITdGDO3jhx037eZvDDYBR2EEn0Lj+M+HtcEMU29ImZO4u
3H4iRJbLOUH8Berjrjn2FAlGSdKqabHsBj1br58SMFqBFj8nF4sEit+sUGPG0Adz
GgaL6aLuPIp0GAhgG/Uo1YxIrNxnM65s+08L3dKKWCn6UFvwIoAjkkOEGm7i662O
fzML6WJkmkdhlrkn+cDeM2qwVqBCMVFH9b6uGBM1uqnsN+o2tMMwW5m4iNbrjz1V
IY06veCGmLZBv6QZl2/bwpHzkOK6RX+NG7qER12Bgt/znOzfIDZbunCeHFtNVlsb
DP0CJc89wVZylqTfV/Q6uDwQFNsi94lvH8qqGw4t1QMTNhBFQHIP9AoABTtxamw6
A+8bn4QCjY0bXrTOHOYz08RtD+7qI/AbCYFMp+9buZkptQxOjCWeBKgtEWdebnAV
2A6Mp/3H3NMqipABkl1DUaxq6IDz8tjjQn5jp1HThq+hIIKiQqIj5KRq371SFY/b
CWAVUnLAP8yb79s/kup9u9I+Zgwm5LWSc1332d45VW8WZ2rJ9zv/zti0qz7ejzIl
uwbGXFmML4QLwhsr28HkGJOxsGnoSTqKosF9h2x81ey1bweyfCI=
=Oywd
-----END PGP SIGNATURE-----

--Px/GKJAInXPYn7yT--