public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: meson: Non-feature feature options
Date: Wed, 8 Feb 2023 11:45:05 +0100
Message-ID: <[email protected]> (raw)

Most meson options (meson_options.txt) that enable an external 
dependency (e.g., icu, ldap) are of type 'feature'.  Most of these have 
a default value of 'auto', which means they are pulled in automatically 
if found.  Some have a default value of 'disabled' for specific reasons 
(e.g., selinux).  This is all good.

Two options deviate from this in annoying ways:

option('ssl', type : 'combo', choices : ['none', 'openssl'],
   value : 'none',
   description: 'use LIB for SSL/TLS support (openssl)')

option('uuid', type : 'combo', choices : ['none', 'bsd', 'e2fs', 'ossp'],
   value : 'none',
   description: 'build contrib/uuid-ossp using LIB')

These were moved over from configure like that.

The problem is that these features now cannot be automatically enabled 
and behave annoyingly different from other feature options.

For the 'ssl' option, we have deprecated the --with-openssl option in 
configure and replaced it with --with-ssl, in anticipation of other SSL 
implementations.  None of that ever happened or is currently planned 
AFAICT.  So I suggest that we semi-revert this, so that we can make 
'openssl' an auto option in meson.

For the 'uuid' option, I'm not sure what the best way to address this 
would.  We could establish a search order of libraries that is used if 
no specific one is set (similar to libreadline, libedit, in a way).  So 
we'd have one option 'uuid' that is of type feature with default 'auto' 
and another option, say, 'uuid-library' of type 'combo'.

Thoughts?

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: meson: Non-feature feature options
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox