Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwJj7-0000Rb-OO for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Apr 2017 02:34:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cwJj7-000842-Am for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Apr 2017 02:34:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cwJj6-00083t-Rp for pgsql-hackers@postgresql.org; Fri, 07 Apr 2017 02:34:16 +0000 Received: from mail-yw0-x234.google.com ([2607:f8b0:4002:c05::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cwJj0-0000un-5o for pgsql-hackers@postgresql.org; Fri, 07 Apr 2017 02:34:16 +0000 Received: by mail-yw0-x234.google.com with SMTP id p77so28997235ywg.1 for ; Thu, 06 Apr 2017 19:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=6X8Us/6YfhNbN/7WUshGPWHMgL6lhix3DfmRK520buU=; b=oH/pyZyp9mrmQ+M5qrTxyfNrCQZAY3uasWqAyWzGF1b2Hak+yggHWid5H9AnSbZRvX G6s9Gi5HNWE8a6qzFCvZJyWtNE3funFT0Jy11657/pe8XSRJ1dfFcD5cdNbqsNXcOzu7 EIr9o5G82NEmeINlMtfEKkNaepx4Ia7wDHUiUasCcWmGMeXZUjbZJCi8+hFqanD7uRfK 9VTXQ4UY5K/03ipovY2m2rbddJ1t5Gryb0LDdagqAhuWUMk64gcAbc52NZsXinRV+uNm JtKyrwStOxIBp/C7AT5Ch+Syp0A4ESSw/R6VOdUyl29f1VHaXQb9gIGnGKPok4VbEnV/ SdHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=6X8Us/6YfhNbN/7WUshGPWHMgL6lhix3DfmRK520buU=; b=AjiYnRvrQpNncaCN/Np/fVANUPcyQarOqcpjhQ5UDhTLd6TENl1O6kuL4/jmCZdma/ IONvzykgSYCqEXXNE7X8j0qLN2phSyvFshyGDVSzVACwygNA9b8FL55ULqHS6GwC3SpY qYkskbYm6++AO2vd3/LzbZnXRQbj3KTio85IGWDEPO+ZytS9WsrbIX8ybVLwQgsqpKmY vYq8s/cr48LDJtss08CScuKBl7UWCCEF/ZRevsRQ1P8ajG29lVHVQXBS4ATewaLEEsK5 e2jzc+/Urxx4sWfMCTFONHWNYHMd4nodJ3ya87qPNdIPGWctPuriKR7bvZVgQqhipWWH 4FUA== X-Gm-Message-State: AFeK/H1uyXvA8Pif8WU3TvovijF/ozLx+QRA4nzGn7Vo7QHmdDDkMwCdGqdeL0uJK8olYeGmGag9KsBpFgUeZh2t2EW1/LB0Gj6Ane5Y8xLTg6QN1KE5a9PPC+GlEfXWnXf6Pa1yX96ZAWAeKQ5y7ajaOFFsKrExGCfkfhT48pjKqSrfzbX1S7jPf2fu0QQREGIeh4ybmAPxO5c= X-Received: by 10.129.102.136 with SMTP id a130mr25145965ywc.144.1491532448207; Thu, 06 Apr 2017 19:34:08 -0700 (PDT) Received: from [192.168.10.146] ([98.122.164.227]) by smtp.gmail.com with ESMTPSA id f6sm1446160ywd.78.2017.04.06.19.34.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 19:34:07 -0700 (PDT) From: Andrew Dunstan X-Google-Original-From: Andrew Dunstan Subject: Re: PATCH: recursive json_populate_record() To: Andres Freund References: <687e19a7-14e2-d0f5-2bff-35d62bc5c05a@postgrespro.ru> <934.1485111512@sss.pgh.pa.us> <9e21a39c-c1d7-b9b5-44a0-c5345a5029f6@postgrespro.ru> <13020.1485377905@sss.pgh.pa.us> <295ad4a5-2923-1834-5140-35d0b9a5818c@postgrespro.ru> <16179.1485380983@sss.pgh.pa.us> <9bf14a7c-0794-f90c-c012-8dd0335ab364@pgmasters.net> <754780af-d905-9704-cf4d-b64e632b86a3@2ndQuadrant.com> <20170403211741.7ommm5dssfv3abo6@alap3.anarazel.de> <45c0aa55-1b62-c622-31fd-cb21e017d5cd@2ndQuadrant.com> <8fcd9e65-acb0-8221-ef23-01e5c2fe90e4@2ndQuadrant.com> Cc: David Steele , Nikita Glukhov , Michael Paquier , Tom Lane , Aleksander Alekseev , PostgreSQL mailing lists Message-ID: Date: Thu, 6 Apr 2017 22:34:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <8fcd9e65-acb0-8221-ef23-01e5c2fe90e4@2ndQuadrant.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 04/05/2017 07:24 PM, Andrew Dunstan wrote: > > OK, I have been through this and I think it's basically committable. I > am currently doing some cleanup, such as putting all the typedefs in one > place, fixing redundant comments and adding more comments, declaring all > the static functions, and minor code changes, but nothing major. I > should be ready to commit tomorrow some time. > I have committed this. I will continue to work on adding comments. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers