Date: Sat, 4 Apr 2026 19:34:13 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org,
	Peter Eisentraut <peter@eisentraut.org>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>
Subject: Re: PG 19 release notes and authors
Message-ID: <adGf9ck_O9NjkOLp@momjian.us>
References: <adElLtegJxi6Yecv@momjian.us>
 <CAEze2WgLEa_vHO9jJY+HRahToV9W2CfWwQUVoCObUQ46Y4_7Mg@mail.gmail.com>
 <e7722b64-cbf8-4a20-967b-698586740d1f@eisentraut.org>
 <5047DBF5-DE47-487A-9955-3A8BA4F26F83@anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5047DBF5-DE47-487A-9955-3A8BA4F26F83@anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/adGf9ck_O9NjkOLp%40momjian.us>
Precedence: bulk

On Sat, Apr  4, 2026 at 06:16:10PM -0400, Andres Freund wrote:
> Hi, 
> 
> On April 4, 2026 5:56:01 PM EDT, Peter Eisentraut <peter@eisentraut.org> wrote:
> >On 04.04.26 17:06, Matthias van de Meent wrote:
> >> On Sat, 4 Apr 2026 at 16:50, Bruce Momjian <bruce@momjian.us> wrote:
> >>> 
> >>> In the PG 19 commits, I am seeing several commits with Author and
> >>> Co-authored-by tags.  FYI, I think we agreed that only the Author names
> >>> are mentioned as the authors in the release notes.
> >> 
> >> If it's not the "Co-authored-by" tag, how else would a project of a
> >> non-committer cooperating with a committer be tagged?
> >
> >Two Author tags.
> 
> That's not how I understood its use so far, and I'm surely not alone in that. We could rephrase this in the wiki page, but we can't go back and edit the commit messages...

The wiki page says:

	https://wiki.postgresql.org/wiki/Commit_Message_Guidance
	Author:
	Co-authored-by:
	    Used to indicate the patch authors. "Co-authored-by:" is used by
	    committers when they want to give full credit to the named individuals,
	    but also indicate that they made significant changes.

but I am seeing many cases where there is an Author tag, who is not the
committer, and also Co-authored-by tags in the same message.  That does
not follow the wiki text.

I need to know what to do for PG 19, and what to do for later major
releases.  I think Peter's point is why are people using Author and
Co-authored-by in the same commits, and not just two Authors.

I thought we had this resolved but looking at the PG 19 commits,
obviously not.

To clarify, I assume Co-authored-by would appear in the Acknowledgments
section at the bottom of the major release notes, e.g.:

	https://www.postgresql.org/docs/current/release-18.html#RELEASE-18-ACKNOWLEDGEMENTS

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.