Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 5 Apr 2026 21:04:53 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Lukas Fittl <lukas@fittl.com>
Cc: Sami Imseih <samimseih@gmail.com>, zengman <zengman@halodbtech.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Julien Rouhaud <rjuju123@gmail.com>
Subject: Re: Refactor query normalization into core query jumbling
Message-ID: <adJP5aQ3TE5ay1J5@paquier.xyz>
References: 
 <CAA5RZ0ui6JSDPQDs2RW7eBDvrH_t_xg8bhUM8FaxawU8wDoMFg@mail.gmail.com>
 <8437F4D0-9DFB-4045-9318-CC3C5BA2E267@paquier.xyz>
 <CAP53Pkwb2f288Ji2s9ZZTL0_PEyYCZpQjBtD63X_s+yUB3YORA@mail.gmail.com>
 <CAA5RZ0vrXNndS6rGx43q+h9JNtxnUzZnxgP_zWSc9LHXS36bXg@mail.gmail.com>
 <acsMzhxJ6lGbbel5@paquier.xyz>
 <CAA5RZ0ufGxCCoPBHKV2mLo9CzHe83w1L-mhx5XHU4axXkMHirw@mail.gmail.com>
 <CAP53Pkx2s7O_fbmLoReKMeOXwp9Z=9e3uW4Tp9RMw99z_dSaiQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2G6yd55OqT5eHpwF"
Content-Disposition: inline
In-Reply-To: 
 <CAP53Pkx2s7O_fbmLoReKMeOXwp9Z=9e3uW4Tp9RMw99z_dSaiQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/adJP5aQ3TE5ay1J5%40paquier.xyz>
Precedence: bulk


--2G6yd55OqT5eHpwF
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 01, 2026 at 12:55:28AM -0700, Lukas Fittl wrote:
> On Tue, Mar 31, 2026 at 7:54=E2=80=AFPM Sami Imseih <samimseih@gmail.com>=
 wrote:
>>
>> > I'm +-0 regarding this routine, but I can also see your point about ho=
w it's
>> > useful to give at least the option to extensions to have a
>> > recomputation of the Const lengths, the same way as PGSS.  What are
>> > the extensions that would use that?
>>
>> https://github.com/search?q=3Dfill_in_constant_lengths&type=3Dcode
>>
>> A few well-known extensions/tools out there based on a Github search.

FWIW, this search points to a lot of forks

> See attached a v9 that extracts ComputeConstantLengths from Sami's v7
> for easier discussion.
>=20
> I've done an updated test with pg_stat_monitor [0] and pg_tracing [1]
> with that, and that has both extensions passing regressions tests.
> I've also looked but not tested a third extension (sql_firewall) and
> that looks like it should just work as well.

Still I can see the gains here, so I guess that this version works
here.  I'm happy enough to see the const with JumbleState.
--
Michael

--2G6yd55OqT5eHpwF
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnST+UACgkQnvQgOdby
QH3+5hAAkILmUgd1GsJNN3T7jI/Wcv5lLYUOJb0zGA3hJr9k6L3RMQt5nDK1KEiR
hRHFqaBiq7yNfVHn13ir528EHXQfmaJAzYAzEbJdB9TBvdz07X5SytQlhoqg6zXN
r9TC0U3BOp0jduRHnSVn1KO+ciOOXxiuu9JqpQB2FWDVYEtve7H/lEYOdOOaC+d8
i7flQIq4zzAVzRj/H68wWByZQmM97gpr0YuuyDj20mA5dQyAhd6nE1PzOMkRckhC
+399SxkmzFy92qgtTaJhPYOqTLnvrx0KfCSiH/yZa/l0GfrITBiqzSPakBboFBaG
gBDYkK+n62g7K9w4aTAGme4auscTMlIEwcX7ozxISYn/KSbB3V3JO23BU4WaPxJX
bk+sFXYsIuLteFw60AFURDzMNrrxpOyOLD4sOjeXaJwAxuGKBaKJTBmBc+nnJkLh
B2v47fGf1TJh3ns94ENkxOlLPyaWQElTv+5UrsXHY6EfFopzaVd8bOppK/6BEoE7
gNGyx5KR53kxE8sRHm7jA+sPB7U0OWm8V5nRfJm1ksb3uBpSzF7aH5Y8N/qXX+ZV
8sT2D6Em78qG1tOjODaU+T+QkRto7z+2ZoZ+6hvKxg10yOb4T/WScfWwNr/uIsQK
YwBsvPAoLpVBcfpsh82Yx4r71G1DipH603o4eNToubyGjEw+CnE=
=VnmN
-----END PGP SIGNATURE-----

--2G6yd55OqT5eHpwF--