Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w9wkC-001unY-0S for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Apr 2026 03:04:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w9wkA-00DhHd-1y for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Apr 2026 03:04:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w9wk9-00DhHN-2R for pgsql-hackers@lists.postgresql.org; Tue, 07 Apr 2026 03:04:46 +0000 Received: from fout-a3-smtp.messagingengine.com ([103.168.172.146]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w9wk6-0000000116G-3nID for pgsql-hackers@postgresql.org; Tue, 07 Apr 2026 03:04:45 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 51CBBEC00E5; Mon, 6 Apr 2026 23:04:41 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Mon, 06 Apr 2026 23:04:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1775531081; x=1775617481; bh=jr7xcj0Cxr 1ZALJdQxnl3MedwXblziRxWBVjl2/Hi0s=; b=HI4exygs9Oq+2fpwS+gxXDWgpY d90yF1FF6paKaVrkjCd/1eZa01PJTphmrs+3T2uZoZVh5AG93eN6m/xeqKsz77JK lkGFAXnTz4Fw5+pk0+INpDZx4YGbKb0wlqI+QPKh7BQl1XUy12vy4V0USxtyJquD 7PR/GPUDsevQwysrJVakq9lyqHsq5W+zmuOIWBBNY3YjLjNPq3d9Q0uYuoxAmKH6 KSTPty+7XzdkjdB0bHjCA6fmICAu0PvoItfAFzeDnBYngSN0IAfOD6os56003ddN WzxEG0d1zpBFAj0ol+MzJFRj6kQknehcw9S9SKgJA2zevf09TJSwWkluQJlw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1775531081; x=1775617481; bh=jr7xcj0Cxr1ZALJdQxnl3MedwXblziRxWBV jl2/Hi0s=; b=Zryi57Ly3lQ7PcHylugxNWSHKJ0v9ZpAhneHk18tlu2Hxz9gBqK R9Psgo4YDR9Bgg2LVsQLcwlgaviERcXboWby0mIGRChYGeSpY5YsXuJssnoWK9MC DxxsoMp28ABYjU8Ze0kMBP9ptqP1vGfEeHkSTqLOsAExajv4z7H7a2QvH2dIia4L dnY0fK5aLRwh2rpVzy9huDcTBzsyXhi1KbMa+zEAJF50wJINXoEHAh/JGyFX2klS nKaMNCdAOaBMrJ6Uv7vCgxCgLrZ398DX14/Fo4oAJkNR8N+f6yqx8WMVodud9jgy T1hfdvcvgkD7UnWyJ/3qucEngN5vf/Mwrag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduleehudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeggeff hfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehhlhhinh hnrghkrgesihhkihdrfhhipdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrshesphho shhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Apr 2026 23:04:39 -0400 (EDT) Date: Tue, 7 Apr 2026 12:04:35 +0900 From: Michael Paquier To: Heikki Linnakangas Cc: "pgsql-hackers@postgresql.org" Subject: Re: Shmem allocated wrong for custom cumulative stats Message-ID: References: <04b04387-92f5-476c-90b0-4064e71c5f37@iki.fi> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NUrz8wjJtjfJdPFk" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --NUrz8wjJtjfJdPFk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 06, 2026 at 12:14:06PM +0900, Michael Paquier wrote: > The attached is working correctly. The v18 flavor is slightly > simpler. I have looked at it again today, and noticed that the test modules of both HEAD and REL_18_STABLE were incorrect in the values they set for shared_size for the fixed-sized cases. In both cases we were finishing with an underestimation. I could only see a direct impact on HEAD for the 32-bit builds, though, but the problem was the same. The allocation has been fixed in 17132f55c5a2, with the modules handled by 98979578055f. -- Michael --NUrz8wjJtjfJdPFk Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnUdEMACgkQnvQgOdby QH1LJw//U/3dF1gn/9OKLvG38oeETeAIGjoT11JmEwrowCrdXfs5axfOY2wbu4o0 6sbDyYbMxaDFJ2C7PbRwsCXwSOi+rqSOqveejhJ5fyH7iVyqYx53Fk7LlZORonSp GI2Gpl4ZpR63puEaethJrH1HZ5ZhAvwx7kBmDLtupS6OwGNKNGiwc6PSkmQdZSi8 wVmd6kB1wkc3m4Ze3I4Q4gdPOCSuX0Gs5KLLScG4UI27qqHlWAAbKIqHmoTwE+h2 9smDQiFdbBxhqTdyFerYZK+fFFfZ1EVS2hlCoeT0ONhoVyaQSiu1mPjiupKvJPsE yBiHikUyGbrk0uAykirwjI45X4BzFaOhJlDnRfb1sC0GWrydwSthrkyh03sIJoQY PQaraMDMtKQtKy3AAFL/hasXAh7bR3AyZ5COns6OWPTTSC3gdDSRoOWSIWqubnnE NKX4iVBjEQ4LopZuCxgzi7AfrDGphzbDEcsSyDp37+OIkiaTHeGhX3YPNV0fvg8h lV15bkiifZTh1tN+1mmhsO/kwpeOofE/dd8H81MsOpQEUe0uav2PcHGYW66aRe2H 3oHBAQMtn9TbhJ62i5ZjAm5Q3KQ2PqOxlW3uggaz5KwFoLME/Dhvf2Ug2p1YZBPD oWXnxf8FHLFgheTdc6lJe/JoKx48N4KiQIpQxDlWtzwW3D8zlwk= =q6o4 -----END PGP SIGNATURE----- --NUrz8wjJtjfJdPFk--