Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 8 Apr 2026 11:28:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Andreas Karlsson <andreas@proxel.se>, Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier
Message-ID: <adW9PfgAeq6hKUjU@paquier.xyz>
References: <aY7fvvxFG8gPdA_d@paquier.xyz>
 <1b901fbf-655d-434c-aff4-ee06313d31cd@proxel.se>
 <aZLLjKC-SS4N93bo@paquier.xyz>
 <aZQRnmp9nVjtxAHS@paquier.xyz>
 <4be75b7d-587f-4217-b0ed-396949d90b43@proxel.se>
 <aZQt88RiILCwqCMq@paquier.xyz>
 <aZUlK0NHoPucwlUc@paquier.xyz>
 <vlcexdcimsmvu3aplt2yxpfndkgtuvjsrms2fdl46rbw3k2kug@drspkoxlaije>
 <adL31OAB8L7EVRFJ@paquier.xyz>
 <l2nw7a55equak3kh2wbjfrllcfrgltwkex6zvjqylxupooadnf@3uf2ey6rbwxz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="oRa2YJNDB3qCyDqN"
Content-Disposition: inline
In-Reply-To: <l2nw7a55equak3kh2wbjfrllcfrgltwkex6zvjqylxupooadnf@3uf2ey6rbwxz>
Archived-At: 
 <https://www.postgresql.org/message-id/adW9PfgAeq6hKUjU%40paquier.xyz>
Precedence: bulk


--oRa2YJNDB3qCyDqN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 05, 2026 at 10:09:48PM -0400, Andres Freund wrote:
>> The trick in genbki.pl was needed to avoid some noise due to -Wenum-comp=
are
>> in a couple of files.
>=20
> You mean the include guards?  Seems they should be added regardless of
> anything else.

They would be needed with this patch.  Now we don't need them as
syscache.h is the only location where syscache_ids.h is pulled in.

> ISTM a better direction would be to make MAKE_SYSCACHE(name,idxname,nbuck=
ets)
> declare something like
>    extern SysCache name;
>=20
> where SysCache is a forward declared struct type with the definition priv=
ate
> to a C file or an internals header.
>
> And then have genbki emit definitions of those that gets included into a C
> file. That struct can then have all the necessary spce to avoid having to
> having to allocate as much and perhaps even get some of the metadata spec=
ified
> at compile time, so it doesn't have to be redone in every backend.

Perhaps. not for v19 for sure.

>> Would you prefer a different option?  That would protect from large
>> rebuilds should syscache.h be touched in some way.  A different option
>> would be to move get_object_catcache_oid() and
>> get_object_catcache_name() out of objectaddress.h to a different
>> header, limiting the scope of what's pulled in objectaddress.h.
>=20
> I frankly would just make those return an integer.

Not sure about that.  We know what we are getting by calling this API
with the type defined, at least.

>> Anyway, the attached should take care of your main concern, I guess?
>=20
> It'd be better than today.  I don't like the syscache ids being known
> everywhere, but it's better than those being known as well as the rest of
> syscache.h.

Well, the main point being to be able to detect breakages more
carefully, I am still curious to see where this experiment will lead
us, so I'd be content to leave the code as-is on HEAD, adjusting
things based on what I have sent in my previous email.  If we are able
to detect one problem, at least, that would be a win for me, and the
solution of HEAD is much better than creating fake routines to tell
ABI detection libraries about the existence of the enum, at least
that's my take.

If others have any comments and/or opinions, feel free of course.
--
Michael

--oRa2YJNDB3qCyDqN
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnVvT0ACgkQnvQgOdby
QH07lRAAlv+8pS5NpGL/KfkR8wLOp56nylXzHMLhVn2WXjtH8lnoXYMG5m45GSp+
mUbmHIOJ2+6Zgc6PkQZTgEjAg2b9CKDRbtGGYrNWQ3sixXCS4WYP6pIA7ZLMPyJU
yH4oXeq8S5wnkTFdl+KUR8cIKBHjwHSVW0M47M9/Lm5aKpV1o3SJKYqbBDhUUjpW
2FwARKDFo9SwUM73MEa+GiSghv93aWTIoQTVXpeCYmugH6fBNHokBpViM/f3VYH5
zMVBv9zZW8pihwSDM2tjtNbwr7VGeT7M1WNC31s4SODZMYVxPDNWuVSUh8oXK6zG
BVHLT9qAXvgnJW73lbILgm1YN7iXyWew0KuffQZ9Z7L9UujZPXCgRlfCBfDTkcFb
k+vlI/IjSvf1gPl8PptwkK6H5gaGK74H1z8h4KhMCmfJPgFv1l0GQ0SEDhZtaoRW
G+saEtTydZRSkKfIpqJMsZpyW8qWGRWH7jQRlnL5Gyk7y5JdYF+AvR+8mUikWQgr
uNaHFyowmjpuw+t72ye+l1gf8eAV+RuAGbfoCzcziJQmNPSI8ma6CXthyrmR+16p
R3Mvr47tXrxtQ0/+urSkJ+swLhp3ua7kc6RuPYh9p9RLhgQLE4uShZq9Xvi0pOk6
aqqrSuwUgJtooAmVFm5WHSQ0IK2R1lR2gjyIBidfRZx40Xnwd/0=
=q+Mj
-----END PGP SIGNATURE-----

--oRa2YJNDB3qCyDqN--