Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 8 Apr 2026 08:30:36 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Jeff Davis <pgsql@j-davis.com>,
	Greg Sabino Mullane <htamfids@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Adding locks statistics
Message-ID: <adWTnO4ulh1WDIGa@paquier.xyz>
References: <acQ9gnE84897xHfQ@ip-10-97-1-34.eu-west-3.compute.internal>
 <acRqbLtT-aJDRSRl@paquier.xyz>
 <acSwlC46/WhYZuy5@ip-10-97-1-34.eu-west-3.compute.internal>
 <acTX8bbXh9lgOvZL@paquier.xyz>
 <adL4u897hLceqYmc@paquier.xyz>
 <rp6wz4lnz5qn4zlh7uxtavzfrmqvycy2g42z4zasfss2gxi54f@zzcsjdvdflwp>
 <adNQjbY7QvWe_W4m@paquier.xyz>
 <adNUBGqGK2YB1azG@paquier.xyz>
 <adSGU67l6NQWg_m7@paquier.xyz>
 <adSdpIjMWRR7YmbK@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kdYBrQRryCj9v2Zq"
Content-Disposition: inline
In-Reply-To: <adSdpIjMWRR7YmbK@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: 
 <https://www.postgresql.org/message-id/adWTnO4ulh1WDIGa%40paquier.xyz>
Precedence: bulk


--kdYBrQRryCj9v2Zq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 07, 2026 at 06:01:08AM +0000, Bertrand Drouvot wrote:
> That looks to work, thanks! But I was wondering if this new version is not
> introducing a new race: the injection point is not local anymore so it co=
uld be
> that another process reach the new injection point. That said, even if th=
is is
> the case I think we're ok since s2 is using "query_until" so we could say=
 that
> "at least" s2 reached the injection point. The new version does not ensur=
e that
> "only" s2 reached the injection point but I think that's safe.

Yes, the lookups based on pg_stat_activity should be enough, I hope.
=46rom what I can see, the buildfarm is silent this morning for this
test, as much as [1] in the CI, so I'd like to think that we are done
here.  Again, I'm hoping so.

[1]: https://cfbot.cputube.org/highlights/all.html
--
Michael

--kdYBrQRryCj9v2Zq
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnVk5wACgkQnvQgOdby
QH1LaRAAmqubnt0LyzzyzjOrnpJuw869pp4Inn79tffbVsBh5qLSYIo3tn/PnXYd
6zXAbEVsNIa1c0G9D6wYYblahDW+AsnKCwUFIyJbXrSg8WVwpV7AInTTmIAtpg37
srdf8URfz7Fg/qSlHQQ7A+E1byffY8pi7k7Xsz6geWCaY+tD5GNx63yQ9q0GxdW+
0G5RVP2gSGeX6x3lfFeD7pu2ubsqUM+NeY882Cnfwm3VrJbtItqhgfgbug2o184x
a2HFDA2CxaBUYw7LLRih6m73sbuZhlLZg5474hbhUu18MHI9rvE6CFDW1u9zrYJN
AvdDntnO1DM5EJxe7Yellgi+LeY7sPV8AJukUpjHPSTXlkGdlmWcr3lp42PK6ysD
FZktwOGygX4kZ4l+yp2Hj2mhTqHTgodJ81Yyl2qmlTmFY+fsodAkOjp4UH3D0VAB
oOrufnkbqY7OwNbq+b2j0MTVdauQ6wLxWKFCtVzNlYxS26aW2ovG2J1aiVxXokcl
tNZGP2jS9+EWOYZSoFYffRQHw4Y29rZZB3MXlOrklH3gm7xA1Wb4Xtt3Xu8yn/lJ
USJFBWpMP6LSbVe5yaXiFmBsAkYNQyety2GF51S7UTdvfcO7AN4bulJh0UKbnHUe
/7vy4zVJUGcF/+xBLfOs5NkyhHrLDyE1Quwc1CwVNnL/VMgq0EU=
=/6Sq
-----END PGP SIGNATURE-----

--kdYBrQRryCj9v2Zq--