Date: Tue, 7 Apr 2026 16:44:05 -0700
From: Mark Wong <markwkm@gmail.com>
To: Andreas Karlsson <andreas@proxel.se>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: updates for handling optional argument in system functions
Message-ID: <adWWxf5YrHATATw3@ltdrgnflg2>
References: <aTiwu9o8vBkLreAL@ltdrgnflg2>
 <ac63G6p1LAdbsca0@ltdrgnflg2>
 <6de20662-36fd-4e00-a0b0-75d1e9deb5c8@proxel.se>
 <9e3ad0f4-c4ef-436b-a5a1-28f600d76a61@proxel.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9e3ad0f4-c4ef-436b-a5a1-28f600d76a61@proxel.se>
Archived-At: 
 <https://www.postgresql.org/message-id/adWWxf5YrHATATw3%40ltdrgnflg2>
Precedence: bulk

On Wed, Apr 08, 2026 at 01:28:29AM +0200, Andreas Karlsson wrote:
> On 4/8/26 12:26 AM, Andreas Karlsson wrote:
> > On 4/2/26 8:36 PM, Mark Wong wrote:
> >> I've attached v5, simply a needed rebase due to some other churn in
> >> pg_proc.dat.
> > 
> > Nice, I like the patch. The code changes looks good and I like the 
> > removal of these duplicate functions and use of default arguments. But I 
> > think the names of the arguments should be aligned with the names we 
> > have in the documentation. And that may mean that we should change the 
> > documentation.
> Forgot to attach rebased patches.

Another rebase needed so quickly? :)  Thanks for the assist!

Regards,
Mark