Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 8 Apr 2026 09:07:50 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Daniil Davydov <3danissimo@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: test_autovacuum/001_parallel_autovacuum is broken
Message-ID: <adWcVrX3jrHPoCmD@paquier.xyz>
References: 
 <CAA5RZ0s+kZZRMSF4HW7tZ9W2jS1o4B+Fg8dr5a-T6mANX+mdQA@mail.gmail.com>
 <CAD21AoDZG6CUE9by0T2N33Zedw4iH0JF=9YoCuniXcugO+ixog@mail.gmail.com>
 <CAJDiXgjQEdssGEQ97UZEKBK5Qc5=urqi1qVLdsJwHbQtsBPH1g@mail.gmail.com>
 <CAA5RZ0tATt=YNy9suA3svMAjw3oBDzxcw8+gMMVHbYG9NBQtRA@mail.gmail.com>
 <CAJDiXgibFmjCvpVojOGCU4DfaqJ3pE+p2BTn_spZNVKrbcGjLQ@mail.gmail.com>
 <CAA5RZ0tExiffcu7qvrUbpq_qqz=zCD2aJ5_Qigo6eP2kgTx3eQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rXNjzPXGmoPAEJ2n"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0tExiffcu7qvrUbpq_qqz=zCD2aJ5_Qigo6eP2kgTx3eQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/adWcVrX3jrHPoCmD%40paquier.xyz>
Precedence: bulk


--rXNjzPXGmoPAEJ2n
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 07, 2026 at 01:02:49PM -0500, Sami Imseih wrote:
> Perhaps, but I don't see it being unreasonable for injection points.
>=20
> I guess we can also think about expanding InjectionPointCondition to
> handle other types of conditions, maybe OID??, to filter when running
> the point.

Yeah, InjectionPointConditionType was designed with these types of
extensions in mind in terms of conditions you want to assign to a
point name when attaching it, with the check happening in the callback
attached when it is run.  It should not be complicated to extend
injection_points_attach(), just pass down a string that it then
translated to an OID, or you could use a different grammar as well.
One thing that I'd be careful about is to handle that with one
argument in the SQL attach function, with the condition data given as
an input string.  One grammar that Alexander K. designed at some point
for some of the facilities he had proposed was a JSON input, but
that's an implementation artifact.

Doing something as a separate module/library would be also fine.  We
do that for the AIO tests.
--
Michael

--rXNjzPXGmoPAEJ2n
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnVnFYACgkQnvQgOdby
QH0snRAAhR/bcEgrkaLkNIa25eArVHZ0H91A0/b/mxe91o6T5LLeuRFm6Wmu9rF/
aZJqYPzLno4i2Lr7Kn2KXnNjtdG5OyWUXhDQuucRujlxySKkNJTdhXpMYBrg9jRz
f/MYfdKUiWHglzFrns5sm90VpDHXOd+jIL51zRu8s+bWwpbifrDOaMgafAqq1MK9
Fz9c8Y7XW6/cwTIa091P+hJFedopPFRwpa50JUehJk0pBvXEZAJ/D16Vkn2P4RSE
vuLBKi4K1+xXCCNkaErz7eE20jYGrRU0G/IutkJG4eXy64ikRMh07sa1g6NJwlgD
kuKeLQtwpckz6FN6h+GHyaUjQMiWedchnYWxHeRkayN1QuS8VE76hXXEwwJF4eNq
3MyljJs4UceG0bIVTmtR63hPwM7LEgpLbvKiJFaigNxQoRaa93tpxf9F66QY0E7V
IPMB31X8bpSlEl4Jl4Vti3fFNUVrP+asNBQ+SDcevp4vGFUdXirMjdBu4xdARsIk
DZyYqRq/H3ElZjRUKR4ML3hXhAlfnH8JWZwNLlYpt7o/fboFTBGv3fMMKi0Hfjwy
MgnNuhCTcZ7mWAUlqc28M0xZGvNcIMyczdNn3pWwfEdHsHooZeWke/CuUcFYNOzU
bY0kb6gZ3DOFzySzq+E78rsRFh0Z9BxQQ0QohvdEef1R+jMUx3Y=
=NT6A
-----END PGP SIGNATURE-----

--rXNjzPXGmoPAEJ2n--