Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 8 Apr 2026 10:04:50 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Thomas Munro <thomas.munro@gmail.com>
Subject: Re: dshash_find_or_insert vs. OOM
Message-ID: <adWpsq8d0GSq6Ao-@paquier.xyz>
References: 
 <CA+TgmoaJwUukUZGu7_yL74oMTQQz2=zqucMhF9+9xBmSC5us1w@mail.gmail.com>
 <CAA5RZ0vNVdBnm_TSCR5K6fT7yc7-jQuneNUYFxFgS7hQnn62sA@mail.gmail.com>
 <CA+TgmoZ3cd+wh1vz8gB_iD9zxZX558xUERaPm7G-M8wa7p9GNg@mail.gmail.com>
 <CAA5RZ0tWjsthTod0ODPEW4noNrSvY+gRWTMxiQ89-yY-k92B8Q@mail.gmail.com>
 <CAA5RZ0uhz2uEtUV1KqoCHKQY4U3pgB6N1n-oR-gy8TPUoenQSA@mail.gmail.com>
 <CA+TgmoYmzRbNjx8sbm_0Hk-VtLBtJPe=juOUSFkm7ge4Xy7hYw@mail.gmail.com>
 <gq55lyolnqm4yv7texawu7sr64btcczktu7hd4byl6zarxkibv@pb6ajailtqop>
 <acXCJODjsCytdpwT@paquier.xyz>
 <CAA5RZ0sX9e2F7ePKxx_805=Wk2BVN2WHhvRhrfd3XBNkvebE9A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mOK33cRYoYZvlMV1"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0sX9e2F7ePKxx_805=Wk2BVN2WHhvRhrfd3XBNkvebE9A@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/adWpsq8d0GSq6Ao-%40paquier.xyz>
Precedence: bulk


--mOK33cRYoYZvlMV1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 07, 2026 at 12:00:14PM -0500, Sami Imseih wrote:
> My apologies for the late response here. I spent some time looking at
> this yesterday and came to the conclusion that we can add dshash tests
> to test_dsm_registry, which already allocates a dshash via
> GetNamedDSHash(). However, I also realized that the API has a gap: callers
> cannot set a size limit on the dshash. I need this for the test, but
> more importantly it's a limitation of the API itself.

As in dsa_set_size_limit() cannot be set for a dshash currently.
Indeed that could be independently useful for some use cases.

> So I plan to
> target v20 for the tests, as it's likely too late for v19. To start, I've
> submitted a patch for allowing callers to set a size limit on a
> GetNamedDSHash()-allocated dshash [1].
>=20
> [1] https://commitfest.postgresql.org/patch/6655/

That's too late for v19, at least here.  Thanks for pursuing this
work.
--
Michael

--mOK33cRYoYZvlMV1
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnVqbIACgkQnvQgOdby
QH13LRAAjAQnR6rDphu8197kXpw9e9Q+/Q7bhcPVIqrblrxXJddVLvPh4iA75kRa
JGpDZ0O+Ao89Q4C4YAsd1oQNdutL1geX89x3nTFpaVlZltKiVwQPcbbD1NsFuOgd
bmj9lrTFOgFG0WLyYCzJkCADXCj/cPH14bIWPF54hspJ2Ee+1/N4gPHZUXm1sUkf
TBra6WGuyFu0vemUQeMgmcLgBaB1me4uGYD+UXxIPhCTkfrCjnbw7FJ98KFF/vBD
156NvGtAIcScTYKt+duPXGguQApGuDEV6cdkdRgioaNO5pQdmVFz7vlWaunWyQKq
P9VXeX3JxDYDvtrOZ4c44asrbnWj3FaBntLydobvEI7SM4Dl8kGAptNsluD+ohey
7/8ayiMh2nM1C/De3OtdkgUMZrW0NOPilH7fSTOvc6kz8DxncIibZRfa/zQxXiyC
TXwVz45twwZwfIrLu4ZN6MHpow8UVZOvxelV58MX8iNmrktFJyg98vlGo6KGOoOZ
9ZA01x0vlJ33oI02BlYLkEweNk6iWmdtxTptnc57oZPKAJcGin5n851HNdulmh/e
RAFevoYDqeqiQq8RBC1cpeEaZzIMHJRF+5vaubhqu/jD0THXeXXTz+TbrAMqoedq
U11HOo7S7TJX7OrfHuplbRnUz0RJQFYg1n+G665furrPR/ub9Rw=
=F7Qx
-----END PGP SIGNATURE-----

--mOK33cRYoYZvlMV1--