Date: Wed, 8 Apr 2026 12:56:09 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Lakhin <exclusion@gmail.com>,
	Sami Imseih <samimseih@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Robert Treat <rob@xzilla.net>, satyanarlapuram@gmail.com,
	pgsql-hackers <pgsql-hackers@postgresql.org>, tndrwang@gmail.com
Subject: Re: Add pg_stat_autovacuum_priority
Message-ID: <adaWuTR7oCKodH7k@nathan>
References: 
 <CAA5RZ0t6bCR6Pasd_eWqXvyUmrNDWmHUy1yN_Po-c4+b9BtBqQ@mail.gmail.com>
 <adEhRzu4YM7ztLXr@nathan>
 <CAA5RZ0vxby2osMMaCuZ=680tmt583cF9n4rOzTGdsiS-1PJknA@mail.gmail.com>
 <adE9RbcA7lhH_w2d@nathan>
 <CAA5RZ0tYzPDeXbqz9uKacRV2xjD055qrg=s3w2PEQPK8EruuSg@mail.gmail.com>
 <adFiCgN22xJ7Z-oR@nathan>
 <CAA5RZ0vRP-W2wJD2OxEb-=VGj2sp5pMCqHQg9YJiuDVPhaY5jQ@mail.gmail.com>
 <adQsdvPPNviWMCXb@nathan>
 <5684f479-858e-4c5d-b8f5-bcf05de1f909@gmail.com>
 <3077290.1775668665@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3077290.1775668665@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/adaWuTR7oCKodH7k%40nathan>
Precedence: bulk

On Wed, Apr 08, 2026 at 01:17:45PM -0400, Tom Lane wrote:
> Alexander Lakhin <exclusion@gmail.com> writes:
>> Please look at a new anomaly, I and SQLsmith have discovered:
>> SELECT (SELECT score FROM pg_stat_get_autovacuum_scores() LIMIT 1),
>>      (SELECT score FROM pg_stat_get_autovacuum_scores() LIMIT 1);
>> ERROR:  detected double pfree in PgStat Snapshot 0x5f6fa4d95d50
> 
> Good catch, but you're not the first:
> 
> https://www.postgresql.org/message-id/CAHewXNkJKdwb3D5OnksrdOqzqUnXUEMpDam1TPW0vfUkW%3D7jUw%40mail.gmail.com

Hm.  I can't get excited about checking pgstat_fetch_consistency (as
proposed in that other report), but I see that commit 02502c1bca added the
freeing behavior in question.  I wonder if it makes sense to just skip
freeing when relation_needs_vacanalyze() is called from the view, i.e., not
an autovacuum worker.  On the other hand, maybe we shouldn't be caching
entries for a view like this that looks through all tables in the
database...

-- 
nathan