Date: Wed, 8 Apr 2026 11:10:55 -0700
From: Mark Wong <markwkm@gmail.com>
To: Andreas Karlsson <andreas@proxel.se>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: updates for handling optional argument in system functions
Message-ID: <adaaL5VD9bfipZQI@ltdrgnflg2>
References: <aTiwu9o8vBkLreAL@ltdrgnflg2>
 <ac63G6p1LAdbsca0@ltdrgnflg2>
 <6de20662-36fd-4e00-a0b0-75d1e9deb5c8@proxel.se>
 <adWWX4jFbxib8oQ1@ltdrgnflg2>
 <b6808c92-9531-4772-aeba-f60535d68b72@proxel.se>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="GzYugJnip6WHHvTk"
Content-Disposition: inline
In-Reply-To: <b6808c92-9531-4772-aeba-f60535d68b72@proxel.se>
Archived-At: 
 <https://www.postgresql.org/message-id/adaaL5VD9bfipZQI%40ltdrgnflg2>
Precedence: bulk


--GzYugJnip6WHHvTk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 08, 2026 at 01:51:30AM +0200, Andreas Karlsson wrote:
> On 4/8/26 1:42 AM, Mark Wong wrote:
> > I don't see any matches when I grep for rule_oid or pretty_bool...
> 
> Sorry for the noise, I was looking at an old version of the docs. The 
> parameters do indeed match the docs. But now that I looked at the 
> patches again I found a real issue which I think should be fixed.

No worries.

> I think the following:
> 
> "select statement of a view with pretty-print option"
> 
> should likely just be:
> 
> "select statement of a view"

Yeah, I agree with that considering that other functions like the recent
get_*_ddl functions have options like that aren't detailed in
pg_proc.dat.

What I pondered over a little bit was whether to flip-flop and remove
the original _ext definitions instead and modify their respective
counterparts that I originally removed. I opted to continue editing what
I started because of the comment that reads "System-view support
functions with pretty-print option", but I don't have any strong
opinions either way.

I've attached v7 with the more succinct descriptions.

Regards,
Mark

--GzYugJnip6WHHvTk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v7-0001-Handle-pg_get_ruledef-default-args-in-system_func.patch