Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u0e7z-00555X-Ms for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Apr 2025 10:18:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u0e7y-00GCTl-2a for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Apr 2025 10:18:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u0e7x-00GCTd-Oy for pgsql-hackers@lists.postgresql.org; Fri, 04 Apr 2025 10:18:21 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u0e7u-003Kh0-0Q for pgsql-hackers@postgresql.org; Fri, 04 Apr 2025 10:18:21 +0000 Received: from [192.168.11.5] (p1696134-ipoe.ipoe.ocn.ne.jp [118.0.93.133]) by oss.nttdata.com (Postfix) with ESMTPSA id 00FA661A52; Fri, 4 Apr 2025 19:18:11 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com Content-Type: multipart/mixed; boundary="------------dIWzhSWpC0qM0xzlXLAujg3H" Message-ID: Date: Fri, 4 Apr 2025 19:18:11 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects Content-Language: en-US From: Fujii Masao To: Yugo NAGATA Cc: Laurenz Albe , Nathan Bossart , Tom Lane , pgsql-hackers@postgresql.org References: <20240424115242.236b499b2bed5b7a27f7a418@sraoss.co.jp> <3602391.1713930458@sss.pgh.pa.us> <20240424210839.GA863220@nathanxps13> <20240426175406.13e47ea3904de814afbfe496@sraoss.co.jp> <20240913161801.b1e60534d77fa9df447b775f@sraoss.co.jp> <9c0c4d7881d2450baf70edb0ae95415a81ac8cb1.camel@cybertec.at> <20250123192220.9bad2b9aec110bf335521276@sraoss.co.jp> <20250403230418.f41b23d155f6c6cb3cebcd92@sraoss.co.jp> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------dIWzhSWpC0qM0xzlXLAujg3H Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/04/04 0:21, Fujii Masao wrote: > Thanks for updating the patch! > > If there are no objections, I'll proceed with committing it using the following commit log. I've pushed the patch. Thanks! While testing the feature, I noticed that psql doesn't complete "ALTER DEFAULT PRIVILEGES GRANT/REVOKE ... ON LARGE OBJECTS" or "GRANT/REVOKE ... ON LARGE OBJECT ..." with TO/FROM. The attached patch adds tab-completion support for both cases. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------dIWzhSWpC0qM0xzlXLAujg3H Content-Type: text/plain; charset=UTF-8; name="v1-0001-psql-Improve-psql-tab-completion-for-GRANT-REVOKE.patch" Content-Disposition: attachment; filename*0="v1-0001-psql-Improve-psql-tab-completion-for-GRANT-REVOKE.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAwMmMxODExYWY0OWI1ZjQxN2FmNzFiNjAxY2I2MDYyMTY0MGExNGI0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v cmc+CkRhdGU6IEZyaSwgNCBBcHIgMjAyNSAxMDo1MToyMCArMDkwMApTdWJqZWN0OiBbUEFU Q0ggdjFdIHBzcWw6IEltcHJvdmUgcHNxbCB0YWIgY29tcGxldGlvbiBmb3IgR1JBTlQvUkVW T0tFIG9uCiBsYXJnZSBvYmplY3RzLgoKVGhpcyBjb21taXQgZW5oYW5jZXMgcHNxbCdzIHRh YiBjb21wbGV0aW9uIHRvIHN1cHBvcnQgVE8vRlJPTQphZnRlciAiR1JBTlQvUkVWT0tFIC4u LiBPTiBMQVJHRSBPQkpFQ1QgLi4uIi4gQWRkaXRpb25hbGx5LApzaW5jZSAiQUxURVIgREVG QVVMVCBQUklWSUxFR0VTIiBub3cgc3VwcG9ydHMgbGFyZ2Ugb2JqZWN0cywKdGFiIGNvbXBs ZXRpb24gaXMgYWxzbyB1cGRhdGVkIGZvciAiR1JBTlQvUkVWT0tFIC4uLiBPTiBMQVJHRSBP QkpFQ1RTIgp3aXRoIFRPL0ZST00uCi0tLQogc3JjL2Jpbi9wc3FsL3RhYi1jb21wbGV0ZS5p bi5jIHwgMjAgKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wc3FsL3RhYi1jb21wbGV0ZS5pbi5j IGIvc3JjL2Jpbi9wc3FsL3RhYi1jb21wbGV0ZS5pbi5jCmluZGV4IGM5MTZiOTI5OWE4Li5i ZGViOTVmYjNjOCAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9wc3FsL3RhYi1jb21wbGV0ZS5pbi5j CisrKyBiL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuaW4uYwpAQCAtNDYwMiw2ICs0NjAy LDI2IEBAIG1hdGNoX3ByZXZpb3VzX3dvcmRzKGludCBwYXR0ZXJuX2lkLAogCQkJQ09NUExF VEVfV0lUSCgiRlJPTSIpOwogCX0KIAorCS8qIENvbXBsZXRlICJHUkFOVC9SRVZPS0UgKiBP TiBMQVJHRSBPQkpFQ1QgKiIgd2l0aCBUTy9GUk9NICovCisJZWxzZSBpZiAoVGFpbE1hdGNo ZXMoIkdSQU5UfFJFVk9LRSIsIE1hdGNoQW55LCAiT04iLCAiTEFSR0UiLCAiT0JKRUNUIiwg TWF0Y2hBbnkpIHx8CisJCQkgVGFpbE1hdGNoZXMoIlJFVk9LRSIsICJHUkFOVCIsICJPUFRJ T04iLCAiRk9SIiwgTWF0Y2hBbnksICJPTiIsICJMQVJHRSIsICJPQkpFQ1QiLCBNYXRjaEFu eSkpCisJeworCQlpZiAoVGFpbE1hdGNoZXMoIkdSQU5UIiwgTWF0Y2hBbnksIE1hdGNoQW55 LCBNYXRjaEFueSwgTWF0Y2hBbnksIE1hdGNoQW55KSkKKwkJCUNPTVBMRVRFX1dJVEgoIlRP Iik7CisJCWVsc2UKKwkJCUNPTVBMRVRFX1dJVEgoIkZST00iKTsKKwl9CisKKwkvKiBDb21w bGV0ZSAiR1JBTlQvUkVWT0tFICogT04gTEFSR0UgT0JKRUNUUyIgd2l0aCBUTy9GUk9NICov CisJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIkdSQU5UfFJFVk9LRSIsIE1hdGNoQW55LCAiT04i LCAiTEFSR0UiLCAiT0JKRUNUUyIpIHx8CisJCQkgVGFpbE1hdGNoZXMoIlJFVk9LRSIsICJH UkFOVCIsICJPUFRJT04iLCAiRk9SIiwgTWF0Y2hBbnksICJPTiIsICJMQVJHRSIsICJPQkpF Q1RTIikpCisJeworCQlpZiAoVGFpbE1hdGNoZXMoIkdSQU5UIiwgTWF0Y2hBbnksIE1hdGNo QW55LCBNYXRjaEFueSwgTWF0Y2hBbnkpKQorCQkJQ09NUExFVEVfV0lUSCgiVE8iKTsKKwkJ ZWxzZQorCQkJQ09NUExFVEVfV0lUSCgiRlJPTSIpOworCX0KKwogLyogR1JPVVAgQlkgKi8K IAllbHNlIGlmIChUYWlsTWF0Y2hlcygiRlJPTSIsIE1hdGNoQW55LCAiR1JPVVAiKSkKIAkJ Q09NUExFVEVfV0lUSCgiQlkiKTsKLS0gCjIuNDguMQoK --------------dIWzhSWpC0qM0xzlXLAujg3H--