Date: Thu, 9 Apr 2026 11:41:39 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Thomas Munro <thomas.munro@gmail.com>,
	Andres Freund <andres@anarazel.de>
Subject: Re: Make copyObject work in C++
Message-ID: <adeQc3I/4dwpeqEb@ip-10-97-1-34.eu-west-3.compute.internal>
References: <DFXV193BOBQ8.1BY2PK8YRJ9O1@jeltef.nl>
 <2h2n2gyw2f4ucicbl3drtdkjt2wzf6b2r4wqm7xwks6vpx5j7n@imymv4hkz5jz>
 <DGDRHFD14I7Z.30DSV2XVI6V93@jeltef.nl>
 <5291d173-1227-4619-b8fd-62336ad292b3@eisentraut.org>
 <CAGECzQSB=rBZ2n1WeCRAQ09xHzHSpyVBk-+NWEAcLsegsRXPzA@mail.gmail.com>
 <6dff90f6-2afb-44a3-9524-b017924d71da@eisentraut.org>
 <DHFMW63NP35Z.3RRS8PIYV508K@jeltef.nl>
 <7ddb8894-3939-4846-8d7f-d886b2cb42ab@eisentraut.org>
 <CAGECzQRauVYN19Y-DTiCTCkdNabh+ZqhdaLrUHR6CAU4wm2TFQ@mail.gmail.com>
 <8f4a2a1e-6142-4481-bc21-76fd33419103@eisentraut.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8f4a2a1e-6142-4481-bc21-76fd33419103@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/adeQc3I/4dwpeqEb%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Wed, Apr 01, 2026 at 07:54:07AM +0200, Peter Eisentraut wrote:
> On 31.03.26 11:09, Jelte Fennema-Nio wrote:
> > On Tue, 31 Mar 2026 at 10:33, Peter Eisentraut <peter@eisentraut.org> wrote:
> > > Hmm, note that C++ is also used for LLVM/JIT, and by requiring this
> > > additional feature set we are also imposing new requirements for those
> > > users.  This has not been fully explored, and I hesitate to add such a
> > > new requirement at the last moment.
> > 
> > I understand the hesitation, but in practice we already impose those
> > requirements anyway for non-MSVC compilers because test_cplusplusext
> > doesn't compile without it. So any compiler that would cause problems
> > with the new featureset would have already complained about that
> > before.
> > 
> > > But how about this: We add the feature test that you propose and enable
> > > the extension based on that.  See attached patch.  This reduces to
> > > essentially a three-line patch, much simpler than all previous proposals.
> > 
> > If you're still worried, then this sounds like a fine middle-ground
> > for now. I think we should reconsider adding the automatic /std:c++20
> > flag for the PG20 dev cycle though.
> 
> Ok, I have committed the shown patch.

d50c86e74375 added a comment mentionning that StaticAssertStmt is deprecated, so
we really need the one added in test_cplusplusext.cpp?

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com