Date: Thu, 9 Apr 2026 10:23:59 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Lakhin <exclusion@gmail.com>,
	Sami Imseih <samimseih@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Robert Treat <rob@xzilla.net>, satyanarlapuram@gmail.com,
	pgsql-hackers <pgsql-hackers@postgresql.org>, tndrwang@gmail.com
Subject: Re: Add pg_stat_autovacuum_priority
Message-ID: <adfEj8Bn4IWbi_wp@nathan>
References: <adFiCgN22xJ7Z-oR@nathan>
 <CAA5RZ0vRP-W2wJD2OxEb-=VGj2sp5pMCqHQg9YJiuDVPhaY5jQ@mail.gmail.com>
 <adQsdvPPNviWMCXb@nathan>
 <5684f479-858e-4c5d-b8f5-bcf05de1f909@gmail.com>
 <3077290.1775668665@sss.pgh.pa.us>
 <adaWuTR7oCKodH7k@nathan>
 <3097984.1775674400@sss.pgh.pa.us>
 <adan_E0o69p81lIj@nathan>
 <3101163.1775676098@sss.pgh.pa.us>
 <adbGfTMw8BiHDMnM@nathan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <adbGfTMw8BiHDMnM@nathan>
Archived-At: <https://www.postgresql.org/message-id/adfEj8Bn4IWbi_wp%40nathan>
Precedence: bulk

On Wed, Apr 08, 2026 at 04:19:57PM -0500, Nathan Bossart wrote:
> On Wed, Apr 08, 2026 at 03:21:38PM -0400, Tom Lane wrote:
>> Nathan Bossart <nathandbossart@gmail.com> writes:
>>> FWIW that elog() shouldn't be emitting anything from the view, unless
>>> something is broken.
>> 
>> [ looks again... ]  Oh, you mean because pg_stat_get_autovacuum_scores
>> passes 0 for elevel instead of any of the valid elevel constants.
>> Can you say "undocumented cowboy hack"?  I'd be happier if we added
>> something like "#define LOG_NEVER 0  /* Never emit this message */"
>> to elog.h and used that.
> 
> Yeah... I should've done that originally.  Here's a patch that I'll apply
> in the next day or so, barring objections.

Committed.  Working on Sami's patch next.

-- 
nathan