Date: Thu, 9 Apr 2026 18:01:58 +0200
From: Sandro Santilli <strk@kbt.io>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Tomas Vondra <tomas@vondra.me>, Junwang Zhao <zhjwpku@gmail.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Eliminating SPI / SQL from some RI triggers - take 3
Message-ID: <adfNduaufvWpIqbN@oli>
Mail-Followup-To: Sandro Santilli <strk@kbt.io>,
	Amit Langote <amitlangote09@gmail.com>,
	Tomas Vondra <tomas@vondra.me>, Junwang Zhao <zhjwpku@gmail.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
References: 
 <CA+HiwqGA5Ay_MR0eJEEbt4j6WrVh4F+AasTp8yCbs5aJLOJn6Q@mail.gmail.com>
 <CAEG8a3JM=NoqiTK0V6S9FNxZPvy1+C5F7rfafTtPKBVWnunL-g@mail.gmail.com>
 <CA+HiwqEyiLCY6MTLbOJXDdLNNQLaURYHvdW797MQgbjEK9od4Q@mail.gmail.com>
 <CAEG8a3+VBpwPf1Rm-ECD90whM9b3YnGhux5CVXdsL6khiBfzRQ@mail.gmail.com>
 <CA+HiwqF2UHzF0sKCp-F2a-U29rqh_9ZPy=f1h+Fh_=M8efj3pg@mail.gmail.com>
 <43b56e3b-80d6-4a45-a313-cb1caa587b22@vondra.me>
 <CA+HiwqE9O6i-h4TUr4A15m06vFedsQROooYgQ69Hx+DR-f+-ug@mail.gmail.com>
 <1290fac7-8430-4d2c-bfcb-00c65adff5e5@vondra.me>
 <adeIhgpWq22E5kwW@hst.kbt.io>
 <CA+HiwqHN0FQbyndiB4bApV8gEZ_tQBC_jr836HL=Mv_ZxK1+Pg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Jfwn5RvyJgNE3cPn"
Content-Disposition: inline
In-Reply-To: 
 <CA+HiwqHN0FQbyndiB4bApV8gEZ_tQBC_jr836HL=Mv_ZxK1+Pg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/adfNduaufvWpIqbN%40oli>
Precedence: bulk


--Jfwn5RvyJgNE3cPn
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 09, 2026 at 08:55:01PM +0900, Amit Langote wrote:
> Hi Sandro,
>=20
> On Thu, Apr 9, 2026 at 8:07=E2=80=AFPM Sandro Santilli <strk@kbt.io> wrot=
e:
> > On Mon, Mar 02, 2026 at 01:34:41PM +0100, Tomas Vondra wrote:
> > >
> > > TBH I haven't noticed the memory context issue myself, I only noticed
> > > because the builds with index prefetch started crashing.
> >
> > We're getting a crash in PostGIS too, since that commit was merged into
> > the master branch, see https://trac.osgeo.org/postgis/ticket/6066
> >
> > The crash is triggered a C function using SPI.
>=20
> Evan Montgomery-Recht posted a report of the same issue on this thread
> a couple of days ago.

I confirm the patch attached in Evan's email [1] fixes the crash for us.

[1] https://www.postgresql.org/message-id/CAEg7pwcKf01FmDqFAf-Hzu_pYnMYScY_=
Otid-pe9uw3BJ6gq9g%40mail.gmail.com

> I have posted a patch to fix the issue, which I will commit tomorrow
> after a bit more testing.

I also confirm your patch v4-0001-Fix-RI-fast-path-crash-under-nested-C-lev=
el-SPI.patch
fixes the crash for us. Thank you !

Let me know when it is time to test again against master.

--strk;

--Jfwn5RvyJgNE3cPn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEEyOAhc1XOBFGVnzBARwiVRt5AyacFAmnXzXUACgkQRwiVRt5A
yadAigv8CWpciExzO24nJ0ngSPlx5ULJEj/qdbAOq+GAxcUk7QEEHSR3CVowbTbS
81rJId0zc2rgX8pOgUGbOnW/2P7z6vahWYdQotpHmDoJal/jbTCifkEfFglZjn5+
wRJ3VZ8reDbF2lEZkyEaPoakfngYdXtgqdxSmlCTQL3yUGTbzRLeudXH5LiktFwm
/+wCbhXJzXTP5ajrl0giYQYm6xxSBkHG7+uTC90uNjN/btp573F++/TCPqElIijF
KjT5KXS8cQdzsIkBxOM7d+hgxVQcNTPnCk4IqP+yrVnBh1ptC9Yv8xC37MO4dk95
ZaR3PwdEvhW7nEm0HlzRPsmr2n5Ia14i4ZAmSqgOLx+AOQ59JWSJkUHnXszLlc41
9dtZoCOtScj3b0kvsogeP4qw6rhwu0N7Xe1VDgIPKuG1ifqqDKGK7nerr69s4rnj
ZQJPvqeoL0YNaJ48Q8WuShKQ5WV/DHAIJbAopj8qctfDfWDfCah8r+ldhZlWhyAR
FMawkEo9
=iFUa
-----END PGP SIGNATURE-----

--Jfwn5RvyJgNE3cPn--