Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 10 Apr 2026 15:12:41 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fix pgstat_database.c to honor passed database OIDs
Message-ID: <adiU2YZ0auyO6jie@paquier.xyz>
References: <ABBD5026-506F-4006-A569-28F72C188693@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ZUat1LXRJaG7ex9B"
Content-Disposition: inline
In-Reply-To: <ABBD5026-506F-4006-A569-28F72C188693@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/adiU2YZ0auyO6jie%40paquier.xyz>
Precedence: bulk


--ZUat1LXRJaG7ex9B
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 10, 2026 at 01:53:15PM +0800, Chao Li wrote:
> For pgstat_reset_database_timestamp(), in most paths dboid is also
> just MyDatabaseId. However, there is one path where dboid can be
> InvalidOid:=20

The call of pgstat_reset_database_timestamp() in pgstat_reset() is a
bug that has to be backpatched down to v15.  It does not make sense to
let a caller of pgstat_reset() pass down a custom dboid and then
decide to reset the timestamp of MyDatabaseId instead.  The call of
pgstat_reset() in pgstat_create_transactional() is the only fishy one,
the other callers are OK.

If we decide to expand pgstat_reset() in other contexts in the
back-branches, we'd be silently trapped as well.

The connect and disconnect calls are less critical, perhaps we could
remove the argument altogether, but I cannot get excited about that
either as some extensions may rely on these as currently designed.

I cannot look at that today, will do so later..
--
Michael

--ZUat1LXRJaG7ex9B
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnYlNkACgkQnvQgOdby
QH0L4g/+KWnob9Y6wazyQ5Yq7kOcRWJQrbvMyOBHYX9rPWnUFcKTU+1vQ+trY3nt
XHRsQ4Va21BX+vnidulcYSGajsPBIbdqRdwNVN0YDwy5CqimYS9kZbMr+szkoMpd
YnqBDN64HhW1Tkg4iX6DIjAAWJA7+AIbyh3p1ag4o8s3gHjnhf84BMqBsQ1Wi2kJ
Vu/EAfgso5GBXybUF3Of4FYZegeR2ampE7WEaFDAfjyb6+S/N6Ia1Ssw3CJKW1Ut
dXrdFWTx/lWbFst4gV8alH4N6Fm5mOEzn9I2LENr9Wzmt1LA3+DSiGFkviE139+T
z0pAZiQbzkRv0A5ixR4U/9onVJDf/LhYmCWtP4ALqYYaWy6bR3OJ/rrSOAVFuEdB
qbhdddu1zJSK+pL9BSwalaIgqMOY69q6OfnuVqbE8d/Wx5+3rLOsyY/BiHXy+B6p
n3RpXXRQNABt5G1lH44x9m3LgFNmCj3mVm4i/5dWyTGZ4ZcTs8H05YmJjTdAaTE2
NCN9+mRJ0MwdEEYz0rfwdA6jV9OCPwhD82KUvw3wU3pVDX3hlKJAOY/0YEeWkSf/
g3g+23yARygzK2tGbAwj9SKhiCcygWIaAvANW0iLT9XGT/XVdcXPjTonPCl9U9o+
sBVJsoab0zsnL+uSaBvrcbEEF+QbDC+0M1Noe1rmI3fZZmeG/iI=
=eLE8
-----END PGP SIGNATURE-----

--ZUat1LXRJaG7ex9B--