Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wBGJc-000tJa-2J for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Apr 2026 18:10:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wBGJa-00DymJ-2i for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Apr 2026 18:10:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wBGJa-00DymA-1m for pgsql-hackers@lists.postgresql.org; Fri, 10 Apr 2026 18:10:47 +0000 Received: from mail-oo1-xc2a.google.com ([2607:f8b0:4864:20::c2a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wBGJZ-00000000NED-0Q26 for pgsql-hackers@lists.postgresql.org; Fri, 10 Apr 2026 18:10:46 +0000 Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-682fce74c06so1829082eaf.3 for ; Fri, 10 Apr 2026 11:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775844645; x=1776449445; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=81cu2u0MhLSoHzKLjV4lm7XHaD0krhvViB2s7x/9Luw=; b=E3w38KCoalE0D8hgE0ERhdCE6ZLuQcnt4IW3lZbv4WaZNFDnlbLITjFcxdnQiFpvLG uuYkSpwX5D5G9O6G+VVvnEjp7Cela8C7A2LTHxWJwQZ2OgfHWrWav5yB4q1JajZi8bYt 8yS6qq2wemBEeKQJTE/ZewdwT2B0G1X0iwZlt6p3uMYxLYlbuZL53yKonJToK3ySt7qW nDlLuxacwkrcWXxGEaaWVCHxuvGItfo5FW53rt5lWjgfBgYXE5dUxkiNi2ipTVuPoz0G NaUZn5ci+VKYIT86kAsv47wdLJEgtwPyjjAeN/kw5WVSlJBUUzG6CyjOoE4jAAvStVde jl3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775844645; x=1776449445; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=81cu2u0MhLSoHzKLjV4lm7XHaD0krhvViB2s7x/9Luw=; b=Cjfwf1T4UpiBNwquAlwN3sezs/IFOtK2Xdj/gkh0hgKrl6Lt3mn0FiWqrFBKxiNqzY pxmwrwvweC7BNt5Y1UcoqfWnU9xx3IpTMvVlDlTHOXD9QhNNUIfchGPb+lEPX9uVcRzK eDPJfp/dUhXI8rIAAjTZt++xoygOEwyYp5VvcMb1GC4r41DWuETV2uOdxk4rdEWkEly6 wGOqPGm3vC4hho85NoUE9zBOJfTFXZROIxru87fXRdNCzxmUtOyH0j4caiYmTQdnB4cB vivdv+b15vFigdyxlImr/Jf1U4fa2p3datZYlHwgdM5QwGVXCYKNDe4SXQczU4BAKAf+ wyJw== X-Gm-Message-State: AOJu0YxBjBOGbe0RxnGjofnvXAu+eJ8btYOUQ0x+pMU4snluKBy1z0NG B5KA1zEQINv/H8tlNSZKWRFKhnjk8CqI7ixvrcD33U5sdGQAF74GL+2t X-Gm-Gg: AeBDieuVnAuHUfgu0tbEyS2VoM7N588a0+Qzs5uZ+WCJfYkJZ2MTDSyl8UQ39Lxj77M o38VsSLRt6qkYVvdrtfHiRmCCHezUN6nFylQuJWpfB+lsOzrMT7Sm6z0+l90utVTksl80Kqd+2r GsKZ56Xzh8RdNomkueRu2xXM7iAeVyaaCHnHBFPlbQLPbw2Rc188c+p772N8ySI/3uh28rYuPM4 LE4g0HWLHg0oXrDHx3DCo+lG+5C2y4EYl/BQf+bIXjNAsCOvvuJTpyNBuueOnjWjY0NvL/qIkSW jSQZ21X1R/sv4RZxaDyc2N1FcoJG8S0Vnqw/+MRPVyjYKISVpsJG0DExhNwAr2Zg0BJV5T+2Geq C7uTphG4r82cpV775c15gdWsdaY5qsmvODidkNVp6FbP9cvy0uziECOvVS04FpZNr9E8nf6IK13 NiWmdnh71xLF/I8XWwsmWX2WSsw5RaGmXvNrQQNO9niJJal9u4m/TmvQKwYBi6JpDi/QU4xZ4U/ toxcZXNS9JiDOra9D3iVfY+I5OlP/VZ X-Received: by 2002:a05:6820:1389:b0:68a:a429:e564 with SMTP id 006d021491bc7-68be57782b4mr1957844eaf.9.1775844644885; Fri, 10 Apr 2026 11:10:44 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-68bcb67e49bsm1894889eaf.14.2026.04.10.11.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 11:10:44 -0700 (PDT) Date: Fri, 10 Apr 2026 13:10:42 -0500 From: Nathan Bossart To: CharSyam Cc: pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Use cached hash to skip unnecessary key comparisons in dshash Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Apr 11, 2026 at 01:09:33AM +0900, CharSyam wrote: > I believe this patch is ready for review. I look forward to any feedback > and am happy to make revisions. Sorry, I forgot to ask whether we could move the "pre-check" to within the equal_keys() function so that it needn't be added to every one of its callers. -- nathan