public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Andres Freund <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Nazir Bilal Yavuz <[email protected]>
Cc: Sami Imseih <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Amul Sul <[email protected]>
Cc: Zsolt Parragi <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Chao Li <[email protected]>
Cc: Anthonin Bonnefoy <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Jakub Wartak <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Documenting coding style
Date: Fri, 10 Apr 2026 09:49:42 -0500
Message-ID: <adkOBpMyt0A6ki5U@nathan> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<CAN55FZ026+y8nJYR5w8miiaQ4Mw8F1xtBdTdR52cDZ4fn2pQ8g@mail.gmail.com>
<CA+hUKG+LekzSbmxbG4u5wDxQ9jHnzxN-wfdZ1pQSZquELmGtVA@mail.gmail.com>
<CAA5RZ0tXWJdL5mTJ8p9RrnThPoja-2LDykUykcbJt5iSjmWe6Q@mail.gmail.com>
<CAN55FZ1wLmdyMs4sABEad2MCKDtbK++F_ztjhkgEtaw+LahycA@mail.gmail.com>
<CA+hUKGJ4JcGNWV0KHD5iChGhJ5Z1F8RXSdxnt2yOoW+KHJuLaQ@mail.gmail.com>
<CA+hUKGJkeTVuq5u5WKJm6xkwmW577UuQ7fA=PyBCSR3h9g2GtQ@mail.gmail.com>
<[email protected]>
On Fri, Apr 10, 2026 at 10:17:44AM -0400, Andres Freund wrote:
> On April 10, 2026 3:57:56 AM EDT, Thomas Munro <[email protected]> wrote:
>> I thought we agreed to stop using Size for new code? size_t has been
>> around since C89.
>
> We really need to start documenting some of this stuff somewhere.
> Deciding something a few years ago, deep in a thread, won't actually help
> anyone but the participants (and maybe not even them) to know about it..
I certainly didn't know this. There's no comment in c.h, either.
> I wonder if we should move the coding style section out of sgml into a
> top-level CODING_STYLE.md or something like that.
>
> And then obviously add things like Size being deprecated.
Unless we're going to actually remove the typedef in the near future, I'm
not sure I'd support even marking it deprecated. If we're going to keep it
around indefinitely, that's just going to become another source of nitpicks
when new contributors inevitably copy/paste some code from the aughts. A
style page makes the situation a little better, but it's yet another thing
that folks have to remember.
To be clear, if someone proposed a patch that completely removed all traces
of Size, I'd likely support it. There is indeed no reason not to use
size_t. (I see that Size has been an alias for size_t since 1998 [0].)
But it's also quite heavily used, so I'd be fine with leaving it around and
considering it fully supported, too.
[0] https://postgr.es/c/0ad5d2a3a8
--
nathan
view thread (35+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Documenting coding style
In-Reply-To: <adkOBpMyt0A6ki5U@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox