Date: Sun, 12 Apr 2026 10:49:38 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: David Rowley <dgrowleyml@gmail.com>
Subject: Use stack allocated StringInfoDatas, where possible (round 2)
Message-ID: <adt4wpj4FZwR+S7I@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="wggHK0nYArblB/da"
Content-Disposition: inline
Archived-At: 
 <https://www.postgresql.org/message-id/adt4wpj4FZwR%2BS7I%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk


--wggHK0nYArblB/da
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi hackers,

Commit 6d0eba66275 already did most of the changes but missed the opportunities
to $SUBJECT in sequencesync.c.

Indeed, 5509055d6956 added a few cases that are using StringInfo but don't need
that StringInfo to exist beyond the scope of the function were using makeStringInfo(),
which allocates both a StringInfoData and the buffer it uses as two separate
allocations. It's more efficient for these cases to use a StringInfoData on the
stack and initialize it with initStringInfo(), which only allocates the string
buffer.

The reason 6d0eba66275 missed those is that 5509055d6956 has been committed
between the patch proposal for 6d0eba66275 and 6d0eba66275.

I used Mats's coccinelle script (mentioned in [1]) to find those and they are the
only remaining ones.

[1]: https://postgr.es/m/4379aac8-26f1-42f2-a356-ff0e886228d3%40gmail.com

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

--wggHK0nYArblB/da
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v1-0001-Use-stack-allocated-StringInfoDatas-where-possibl.patch"