Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 13 Apr 2026 09:16:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dapeng Wang <wangdp20191008@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fix pgstat_database.c to honor passed database OIDs
Message-ID: <adw13WY5N5xp-YVi@paquier.xyz>
References: <ABBD5026-506F-4006-A569-28F72C188693@gmail.com>
 <adiU2YZ0auyO6jie@paquier.xyz>
 <aditMVNDceHtvYj4@paquier.xyz>
 <8CD3DF77-C4F0-4CA0-B329-2B62B5A85E3B@gmail.com>
 <CAKx0YhzpuMkVwxa-fh36YOk11KZ6tjXnApAF=H6Sgso5a+P4Zg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Djy97qQmSHCU6yVj"
Content-Disposition: inline
In-Reply-To: 
 <CAKx0YhzpuMkVwxa-fh36YOk11KZ6tjXnApAF=H6Sgso5a+P4Zg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/adw13WY5N5xp-YVi%40paquier.xyz>
Precedence: bulk


--Djy97qQmSHCU6yVj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 10, 2026 at 09:01:32PM +0800, Dapeng Wang wrote:
> Without the patch, calling
> pg_stat_reset_single_table_counters('pg_shdescription'::regclass)
> incorrectly updates the current database's stats_reset timestamp
> while leaving the shared db entry (datid=3D0) unchanged.
>=20
> With the patch, the shared db entry's stats_reset is correctly
> updated, and the current database's timestamp is not affected.

The coalesce() trick to bypass the fact that the reset timestamp may
not be reset was a bit ugly, so I have used instead a second reset.
I have limited the test to check for datid=3D0, not MyDatabaseId.

There is a bit down in stats.sql an extra portion of the test where we
use twice pg_stats_reset().  One reset could be removed, but I have
left it as-is in case someone decides to shuffle or split things in
this test script, to avoid problems in the future.

And fixed that down to v15.
--
Michael

--Djy97qQmSHCU6yVj
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmncNd0ACgkQnvQgOdby
QH21HxAAizlBLTi3RTjFQblDTjS0hyMdDN9cqz9mG7HaHKclF7RwXckefKPI/wqx
XXdCKcvIs4PHbs5NSWlS6yASBoJfCQGH4DrTO2uy8Aw9+QlyQlVpNv+02aRBu8ZU
DhlBmHnGEn3WZq4jE08dC2a0F8Ww9AUBJ2bpY4tYHaCZeWS4G+DurlECegb8j0ar
3d38duXEDmTluxoHpAGCJhDlBMC300l24xXbSRYB4Z9tctTMnKU3fFbPMY9UFlc+
SCG4e412c0dbxdUScCqjA0r6X0/pff9A641tRmldB0ocpnPTfp9a16p89EUfbt/w
UduSMS4qHNX/QGvA4Yf+tGBmeopPXC0QRAhkis3KIZdpQpXk24WIfJK8WvSnpQI3
m2YqS28xCNrFI5xjpwRIvJgJhjZFlFUlfPX2r0Za/i/SEAqL4brKl0/vR2Qqzp5S
oFBsphVjcy4RDFwF2vVdaGBX3eRnSVcX49ki0ya86ONX4DmhENeGQP3l+U+WkKum
6PfnOSZuU8+5Vujfg6kpcd1hn7Z1q0lyUwM4xCONw+IpXPFvoMjxFLpJ7VRTOOnz
cxxojIpdQ9D+KEwMXQTWzt8W/i9Ha2auPT5ineFNi1vclVVDdUj7JsDXycVMCjOa
z9ZgbCq76YIFFwxgDdGqYuMyRYeBpRl9TphoMfchLMOmjIIoAqs=
=K329
-----END PGP SIGNATURE-----

--Djy97qQmSHCU6yVj--