public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Andres Freund <[email protected]>
Cc: Postgres hackers <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Subject: Re: test_compression, test module for low-level compression APIs (for 2b5ba2a0a141)
Date: Mon, 13 Apr 2026 12:52:59 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <pzafmppohkmqixgswjcyi6lyf2nsmbcyty4l6lciamskjl5nem@3i2am4uetkd2>
References: <[email protected]>
	<pzafmppohkmqixgswjcyi6lyf2nsmbcyty4l6lciamskjl5nem@3i2am4uetkd2>

On Sun, Apr 12, 2026 at 10:20:43PM -0400, Andres Freund wrote:
> There's really no reason for something like this to be a test doing tests via
> SQL from what I can tell.
> 
> If it does not to be via SSL, can we please start to find a way to combine
> tiny stuff like this?  We're working hard at making our tests grow
> unsustainable.

If we care about `make check` rather than `make installcheck`, it
seems to me that a solution already exists in the shape of C function
called through the main regression test suite.  And for the specific
case of this thread, I could live with two new functions in regress.c
that are then called in compression.sql.

Would this idea work for you when it comes to this proposal?
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: test_compression, test module for low-level compression APIs (for 2b5ba2a0a141)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox