Date: Mon, 13 Apr 2026 11:04:09 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, David Geier <geidav.pg@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Reduce build times of pg_trgm GIN indexes
Message-ID: <adzNqZdHrWHYCinj@ip-10-97-1-34.eu-west-3.compute.internal>
References: <e5dd01c6-c469-405d-aea2-feca0b2dc34d@gmail.com>
 <2e11134f-02c3-43da-8c39-fb520a1a251d@iki.fi>
 <66620ec7-0f81-4813-9cf1-b901a56efcc3@gmail.com>
 <CAEze2WiUL9idZBbuUN+MuWqr6DcPr_-C91E9MTx=H62Xx5fHaQ@mail.gmail.com>
 <ef8782c9-68b7-4915-9f79-497765a8e205@gmail.com>
 <a90ebbbd-0d77-49c7-b222-3dbffa4e3b14@gmail.com>
 <2a76b5ef-4b12-4023-93a1-eed6e64968f3@gmail.com>
 <6439c655-e281-409d-b884-6586750d5820@iki.fi>
 <adeNWH5pDawDvvR2@ip-10-97-1-34.eu-west-3.compute.internal>
 <2a2f9cb0-f00d-413c-8517-4a3ad220d104@eisentraut.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="own3bwUg9UcwGn6A"
Content-Disposition: inline
In-Reply-To: <2a2f9cb0-f00d-413c-8517-4a3ad220d104@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/adzNqZdHrWHYCinj%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk


--own3bwUg9UcwGn6A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

On Mon, Apr 13, 2026 at 11:41:02AM +0200, Peter Eisentraut wrote:
> On 09.04.26 13:28, Bertrand Drouvot wrote:
> > 
> > This commit makes use of StaticAssertStmt() that has been deprecated in
> > d50c86e74375. The attached, fixes it.
> 
> I think the position of the static assertion is correct, because it refers
> to the palloc0_array() that follows.  Maybe the comment could be a bit
> clearer, like "using palloc0_array requires GIN_CAT_NORM_KEY==0"?

Yeah that looks better to not lose the connection with palloc0_array() here.
Done that way in the attached and adding new braces to avoid warning from
-Wdeclaration-after-statement.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

--own3bwUg9UcwGn6A
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v2-0001-gin-change-remaining-StaticAssertStmt-to-StaticAs.patch"