Feedback-ID: ie0a040ee:Fastmail
Message-ID: <ae29dfa3-9678-468a-879b-8a4c0e74f826@eisentraut.org>
Date: Fri, 13 Mar 2026 17:00:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Change copyObject() to use typeof_unqual
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <92f9750f-c7f6-42d8-9a4a-85a3cbe808f3@eisentraut.org>
 <a18378cc-69f5-4eaa-999b-1fcfc9b1ed7f@eisentraut.org>
 <b136156d-11d1-4db9-84db-28fd8c0aa756@eisentraut.org>
 <CAGECzQSxqAgF4YA_2C3mBKoTJ1-Mc3uVMAe2AgLjibnv4Ltkuw@mail.gmail.com>
 <ff129805-1516-478a-a438-145880165c58@eisentraut.org>
 <68C5A719-919A-483D-96F9-7D59CEA6D519@yesql.se>
Content-Language: de-DE, en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <68C5A719-919A-483D-96F9-7D59CEA6D519@yesql.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/ae29dfa3-9678-468a-879b-8a4c0e74f826%40eisentraut.org>
Precedence: bulk

On 13.03.26 14:03, Daniel Gustafsson wrote:
>> On 13 Mar 2026, at 11:43, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
>> I committed this and it still fails, but the failure is now narrower. There is a failure on buildfarm member taipan because it uses an unusual combination of gcc and clang (the gcc is much newer than clang).  The only sensible workaround I could think of is a hardcoded override based on the clang version, as in the attached patch.  And alternative is that we decide that we don't want to support this combination, meaning that we would effectively require that clang is approximately as-old-or-newer than gcc.
> 
> I ran into this as well on clang 15 via XCode with no gcc involved:
> 
> ../src/test/modules/test_cplusplusext/test_cplusplusext.cpp:41:22: error: no template named 'remove_reference_t' in namespace 'std'; did you mean 'remove_reference'?
>          RangeTblRef *copy = copyObject(nodec);
>                              ^~~~~~~~~~~~~~~~~

Jelte,

I read here

https://en.cppreference.com/w/cpp/types/remove_reference.html

that remove_reference_t is actually in C++14, which might explain this 
failure, if the compiler is in C++11 mode.

I don't understand the difference between remove_reference and 
remove_reference_t.